commit 76bd0b1aee55e55bece826094be696f4c1ee54fa
author Morten Stenshorne <mstensho@chromium.org> Tue May 31 05:38:45 2022
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Tue May 31 05:53:14 2022
tree 087cc9057020fff8ae7d2c17f281d47fbeb81826
parent 206237ada60313f3fe1c6cf36e3117fd5de30fb6

Pass parent constraint space to child space builder when possible.

Prefer using the NGConstraintSpaceBuilder(const NGConstraintSpace&
parent_space...) constructor, when possible. It inherits a flag from the
parent - "ShouldPropagateChildBreakValues". Failing to inherit this
inside the table layout code was actually causing bugs (see test
included).

The real motivation behind this change, though, is that I'm planning on
adding one more flag here for repeated content (repeated table headers /
footers, and also fixed-positioned elements when printing).

The changes here are all about tables and out-of-flow positioning. We
can now get rid of a couple of members from NGOutOfFlowLayoutPart. At
the same time, now that we're using the NGConstraintSpaceBuilder that
takes a constraint space, we can no longer "cheat" about what the
parent's writing mode is. So NGOutOfFlowLayoutPart::GenerateFragment()
needs to convert the size of the child from the writing-mode of the
child to the writing-mode of the container, and pass that as available
size to the constraint space builder.

LayoutNGMixin<Base>::UpdateOutOfFlowBlockLayout() was also passing an
incorrect constraint space to NGOutOfFlowLayoutPart. It should be
created based on the container, NOT the child. Because of this change,
we now need to remove the DCHECK for formatting context root from
NGConstraintSpace::CreateFromLayoutObject(), since we may now end up
here even if the containing block isn't a formatting context root. But
that's okay, as long as we're not going to lay it out. Re-add [1] an
equivalent DCHECK to UpdateInFlowBlockLayout().

[1] Was removed in CL:1473393, in favor of the one in
CreateFromLayoutObject(), which now is gone.

Bug: 1078927
Change-Id: I28783925326df87311c9894b72f898525daa5811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3673761
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1008987}