commit | f461b6809f1fdb400f8a203a25001d2af121c088 | [log] [tgz] |
---|---|---|
author | Xianzhu Wang <wangxianzhu@chromium.org> | Wed Jul 20 20:04:28 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jul 20 20:15:50 2022 |
tree | 62a6853ba70fc4af6a4aa66057014405a074434f | |
parent | 5fb15e04adca47cc972a2e4c665853aca6a1a5b9 [diff] |
Fix hairlines along edges of mask bounding box in masked layers The following caused the hairlines: 1. Both the mask layer and the masked layer were under the same clip node which clips the layers to the mask bounding box; 2. The mask layer and the masked layer used different raster scales, and mapping clip rects between the layer space and the screen space caused errors. In the screen space, if the rect on the masked layer was bigger than the mask layer, pixels along the edges of the mask bounding box in the masked layer would be visible. We can't force the same raster scale of the masked layer and the mask layer because sometimes they are determined independently for the best result of each layer. For example, we want to use the native scale for surface layers (used for composited videos). To solve the problem: 1. Change the output clip of the mask effect node and its isolation group node from the mask clip to the parent of the mask clip. 2. Change the painted result of the mask layer to the above output clip, so that the mask is no longer clipped by the mask bounding box. 3. Expand the bounds of the mask layer to make sure it always covers the masked layer. This won't change the rendered result (except for slight change in anti-aliased pixels when the surface/texture pixels are not 1:1 matching physical pixels) because the mask layer should be transparent outside of the mask bounding box, and these transparent pixels should mask off the pixels in the masked layers just like an exact mask clip. Bug: 1171601 Change-Id: I85ff66e54eb67d8be01a5791d38622397da3cdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3742680 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026396}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!