| commit | a1611c7e2ddff8ff80d409cf72d59137fe4f3d81 | [log] [tgz] |
|---|---|---|
| author | Mike West <mkwst@chromium.org> | Tue Sep 13 14:37:34 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Sep 13 14:52:09 2022 |
| tree | 5fbe7cad79a9d9c86327e20bc5e6f5f39cad9be9 | |
| parent | 79eaf42c932d8f08f1784562ba4d975e4abb272d [diff] |
Revert two PNA CLs that seem to be causing crashes.
This reverts commit 4f617a2060db8828b6caa16cdd57be12d4ec3af8
("[Private Network Access] Support service worker script update") and
commit ee580dabdb282695447ad86db14c7a0caaecd79d ("Fix success test
cases in service-worker-update.https.window.js").
The former is suspected to be responsible for crashes in https://crbug.com/1362131. The latter was necessary to cleanly revert
the suspected patch.
Original change's description:
> [Private Network Access] Support service worker script update
>
> This CL passes a proper client security state based on the
> ServiceWorkerRegisterJob's policy container polices to GetLoaderFactoryForUpdateCheck which eventually gets to [1] where we
> would use it to create a loader factory just like we did for new script
> fetches. It also initialises policy container policies for the
> ServiceWorkerRegisterJob constructor used by updates.
>
> Now the PNA check will block the public->private/local fetches in wpt
> tests.
>
> [1] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_context_wrapper.cc;l=1651;drc=13dced01cce80364299ad7663479ad65069db73d
> [2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_register_job.h;l=64-65;drc=13dced01cce80364299ad7663479ad65069db73d?q=register_job.h&ss=chromium%2Fchromium%2Fsrc
>
> Bug: 1239551
> Change-Id: I1871153d83ae97e4aba46437e6708d748865052e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3865859
> Auto-Submit: Jonathan Hao <phao@chromium.org>
> Commit-Queue: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1044019}
Bug: 1239551, 1362131
Change-Id: I0e57be7151fa035c191f635c586fac44d7500cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3890988
Commit-Queue: Mike West <mkwst@chromium.org>
Owners-Override: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1046349}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!