commit | 30a7d4fd5ac0e0ab0dfae78989ebc5c376fec747 | [log] [tgz] |
---|---|---|
author | Aaron Krajeski <aaronhk@chromium.org> | Sat Nov 26 22:38:35 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Nov 26 22:59:12 2022 |
tree | 4a23dccf2f412cf0489acde29dfab3b539f2badd | |
parent | 9be67046d1f0d57d0d4fba089f151ef044572f5d [diff] |
Make new InterpolableColor type This makes third_party/blink/web_tests/external/wpt/css/css-color/animation/color-interpolation.html pass in its entirety. It was not taking into account that lightness values for Oklab are in range [0, 100] instead of [0, 1], so the expectations are adjusted here. https://www.w3.org/TR/css-color-4/#interpolation With the changes coming in CSS Color 4, CSS animations and transitions need to change. Previously all interpolations happened in the sRGB color space. Now the spec requires that new "non legacy" colors interpolate in the Oklab colorspace while legacy colors continue to interpolate in sRGB. Crucially, if a legacy color is animating with or transitioning to a non-legacy color the transition should happen in Oklab. Previously colors that were interpolated were generic InterpolableLists. This was fine when colors could be naively assumed to be in the same color space, but is not no longer sufficient. This CL creates an InterpolableColor class inheriting from InterpolableValue. It stores the three color params generically (as opposed to "red", "green" and "blue") along with alpha and the colorspace for interpolation. When an interoperable pair of colors is created, they will check their color spaces to see if they are equal, and convert their values if necessary. InterpolableNumber::Clone and InterpolableList::Clone were exposed as part of this CL. It seems like they should have been all along, its only that InterpolableColor was the first InterpolableValue type to make use of them. Open questions: - CSSColorInterpolationType::ResolveInterpolableColor simply adds in colors, this doesn't seem like it should work? - InterpolableColor::Composite only adds in alpha if the two alpha values are not the same. This is copy pasted from the previous code but does not make much sense to me. Bug: 1365635 Change-Id: I17303067890742e3c67ae9b8cdd1073b7956aea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4024793 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/main@{#1075927}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!