commit | e1400ef4581676b52364c3c7b9587c705c564ab9 | [log] [tgz] |
---|---|---|
author | Yoshifuim Inoue <yosin@chromium.org> | Fri Dec 02 07:05:51 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Dec 02 07:20:40 2022 |
tree | e19f3019aa668d6bdb782c7f46bbce49a6985426 | |
parent | 8646f9fc564439fe5c7582ce5d73a86427a57cf2 [diff] |
[initial-letter] Use baseline alignment for drop, raise, sunken initial This patch changes `ComputeInitialLetterBoxBlockOffset()` to use baseline alignment instead of line-under alignment when initial-letter size >= sink, e.g. `initial-letter: 3 drop`, `initial-letter: 3 raise`, `initial-letter: 3 2` to match the spec[1][2]. This patch also introduces new test: `initial-letter-text-decoration-underline.html` for verifying baseline alignment and underline for the open issue 887[5]. # Details The spec says[2]: If its size is greater than or equal to its sink, the initial letter is positioned to satisfy its under alignment, and then shifted by --------------------------^^^^^^^^^^^^^^^ (sink - 1) × line-height of containing block towards the containing block’s block end. The spec says[3]: This property specifies the alignment points used to size and position an initial letter. Two sets of alignment points are necessary: the over and under alignment points of the initial letter are matched to -------------^^^^^^^^^^^^^^^ corresponding over and under points of the root inline box. Before this patch, Blink uses "line-under"[4], the link is pointed to. After this patch, Blink uses "baseline" as `initial-letter-align: alphabetic`[1]. [1] https://drafts.csswg.org/css-inline-3/#valdef-initial-letter-align-alphabetic [2] https://drafts.csswg.org/css-inline-3/#initial-letter-block-position [3] https://drafts.csswg.org/css-inline-3/#aligning-initial-letter [4] https://drafts.csswg.org/css-writing-modes-4/#under [5] https://github.com/w3c/csswg-drafts/issues/887 Bug: 1276900 Change-Id: I99e0b535f13350856187a5d2af8136c7eef78f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4067085 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1078467}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!