commit | a6305e02ccfe76ec3154e8464a08e387286934f0 | [log] [tgz] |
---|---|---|
author | Xiaocheng Hu <xiaochengh@chromium.org> | Tue Jan 10 02:45:15 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jan 10 02:53:51 2023 |
tree | e77c1f4d560930ad58f1b665c318f6cd497a6c85 | |
parent | a0ddc451e02afbbe600c679fe1edab0e4f878ecf [diff] |
[anchor-position] Always use compositor scroller ids for composited scrolling The existing implementation for composited scrolling is problematic because if scrollers have changed in a style update, then it might access data that is stale or already gone in the subsequent paint property tree building. This patch basically follows the outline in crbug.com/1401827#c2: - It changes Blink::AnchorScrollData to store CompositorElementId instead of PaintLayer for the relevant scroll containers, so that we don't need to access the snapshotted PaintLayer/PaintLayerScrollableArea in PrePaint and Paint, at which time they may have been stale - This also moves the job of scroller validation (i.e., whether there is a ScrollNode on cc side) completely to cc, which is much saner compared to the previous heuristic of checking HasOverflow() on the Blink side - This also fixes crbug.com/1400522, as we no longer create one cc TransformNode in the middle of creating another Note that unlike the outline, there's no AnchorScrollData validation at PrePaint on the Blink side. Since everything we pass to cc are just scroller ids, and scroller id validation is done completely by cc, further validation in Blink is unnecessary. Fixed: 1400522, 1401827 Change-Id: Ief68d18e4484cfbe8d4f1037f5d5cb6c6de9687f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4137178 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1090660}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!