commit | 2d7c53f5bc604132d2c83955537e454ee9c788c0 | [log] [tgz] |
---|---|---|
author | Rakina Zata Amni <rakina@chromium.org> | Wed Jan 18 01:22:58 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jan 18 01:36:38 2023 |
tree | edefddba25b2535893b48ecefceb20b634494998 | |
parent | 2fca8e91a76ef08359b4c69a616765d1e9a2ad3d [diff] |
Revert "Reland "Initialize long task reporting for ScriptPromiseResolver"" This reverts commit a8b255dd89e8756df4e733badd051c4311581111. Reason for revert: Still causing external/wpt/longtask-timing/idlharness.window.html to fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110748/overview Original change's description: > Reland "Initialize long task reporting for ScriptPromiseResolver" > > This reverts commit 93a301433c5f8eeeb7b42f17c7a03e2bc0c7d2a7. > > Reason for revert: WPT issue > Original change's description: > > Revert "Initialize long task reporting for ScriptPromiseResolver" > > > > This reverts commit 7943977c5d425843c086abe84c326b7fb4145838. > > > > Reason for revert: Possible culprit for failing longtask-timing tests > > > > See: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110615/overview > > > > Original change's description: > > > Initialize long task reporting for ScriptPromiseResolver > > > > > > This tells the PerformanceMonitor to report longtasks > > > in promise chains that were not started from a callback, > > > e.g. fetch().then(() => {...long_task}) > > > > > > The PerformanceMonitor relies on different probes for "attribution": connecting a long task with one or more frames, to avoid reporting a long task to an unrelated frame tree that happens to be on the same thread. > > > > > > This design is a bit brittle, as we need to patch through all the things that can invoke a frame-attributed task into PerformanceMonitor. > > > > > > This CL doesn't attempt to solve this brittleness, in lack of a better solution, but rather to mitigate the particular issue with tasks invoked with a promise, by patching through ScriptPromiseResolver to PerformanceMonitor. > > > > > > Bug: 1251964 > > > Change-Id: I745780f834f9d1dfc8e8a5c8295326f06276cba6 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4129480 > > > Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> > > > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1091706} > > > > Bug: 1251964 > > Change-Id: I2841851f39739cdcc65ca8044115173f97cd88da > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4161792 > > Owners-Override: Rune Lillesveen <futhark@chromium.org> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > Auto-Submit: Rune Lillesveen <futhark@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/main@{#1091761} > > Bug: 1251964 > Change-Id: I368fe4d629f7c919d7861a960bf6ec8614b693ac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4164277 > Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1093505} Bug: 1251964 Change-Id: I36db3aa74165d9308bbc9b352f0fc227da2dc399 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4176053 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Rakina Zata Amni <rakina@google.com> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/main@{#1093660}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!