commit | e4df810482bd7cd8d0454ff0ba33c8a9b7991e47 | [log] [tgz] |
---|---|---|
author | Traian Captan <tcaptan@chromium.org> | Thu Feb 02 20:45:13 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 02 20:59:32 2023 |
tree | 92e2aff8ebb6066116f745db896630ebbd29b654 | |
parent | 41ba61f3c06c216611b2f14dbcc1e55032135063 [diff] |
Add resolution units support in css image-set Currently only the 'x' (short alias for dots per pixel) resolution unit is supported, and parsing fails for the other units (dppx, dpi, dpcm). Based on the image set spec, all the resolution units should be supported. This change adds image-set support for all the resolution units, and adds full support for the 'x' resolution unit instead of treating it as only a parse time alias of the 'dppx' unit. Spec definitions: [1] "The syntax for image-set() is: <image-set()> = image-set( <image-set-option># ) <image-set-option> = [ <image> | <string> ] [ <resolution> || type(<string>) ] Each <string> inside image-set() represents a <url>." [2] "Resolution units are dimensions denoted by <resolution>. The resolution unit identifiers are: 'dpi' - Dots per inch. 'dpcm' - Dots per centimeter. 'dppx', 'x' - Dots per px unit. The <resolution> unit represents the size of a single 'dot' in a graphical representation by indicating how many of these dots fit in a CSS 'in', 'cm', or 'px'. For uses, see e.g. the resolution media query in [MEDIAQ] or the image-resolution property defined in [CSS3-IMAGES]. All <resolution> units are compatible, and 'dppx' is their canonical unit." [1] https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation [2] https://www.w3.org/TR/css-values-4/#resolution-value R=futhark, masonf, pdr Bug: 1400903, 1412016 Low-Coverage-Reason: Previous image-set resolution parsing logic in css_parsing_utils.cc Change-Id: Ic05afa3bc1b5ed6927c309426cd55953da7bf0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4201198 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Traian Captan <tcaptan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100612}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!