commit | 14b08e9b23f521bd6410395c13d69a5257d0662e | [log] [tgz] |
---|---|---|
author | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 13 20:58:56 2023 |
committer | GitHub <noreply@github.com> | Mon Mar 13 20:58:56 2023 |
tree | abf0e2898a7ddb02623dd9a44f70a93cfbd493bf | |
parent | 59e7de50d3f688116e71a0fce7f60bf8183db68e [diff] |
Simplify and fix named pages layout. (#38877) If an element had a page name specified, we'd use that as the start page name. But we should rather let descendants get a chance to set set a page name first, and only if no name is propagated from descendants, we should use that of the element itself. <div id="first" style="page:a">a</div> <div id="second" style="page:a"> <div id="inner" style="page:b">b</div> </div> Because of this propagation failure, the start page name of #second would be "a", so we wouldn't insert a break before it (since we're already on a page with that name). And breaking before #inner isn't possible, since there's no valid class A break point before it (such break points only exist *between* siblings). In other words, we depend on the page name to be propagated upwards until we find a valid break point, for this to work correctly. When propagating page names from children, just use that value, not the page name of the container fragment itself, let alone the page name set somewhere in the ancestry. Use the specified page name when finishing layout, but only if no descendants have provided one. Although the spec talks about start and end page names [1], we really don't need to keep track of that during layout. Once we get a different page name, we need to break anyway. Simplify everything. Rather than having a start and end page value in NGLayoutResult, and the page name in NGPhysicalBoxFragment, just keep the latter, and use it for everything. [1] https://drafts.csswg.org/css-page-3/#using-named-pages Bug: 1421421 Change-Id: I70306e6949639208942f547c7bce22b51b3c78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4316229 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1114578} Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!