| commit | a2c3d90657a9d510fc80ded0b4c0317e86c3dfa8 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Tue Mar 28 08:42:34 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Mar 28 08:54:47 2023 |
| tree | 7c28d745a4ec43abc14f9951d10ca4ffbaf03db3 | |
| parent | f08bd0d2268583d20636475bc71deb9faf3ad3cf [diff] |
Consistently encompass fragmentainer overflow in the container. Monolithic content may cause a fragmentainer to be overflowed, and the container(s) of the monolithic node should then grow to hold the monolithic content (and thereby also overflow the fragmentainer), if allowed. Some of the tests included here were already passing, but not all. For block containers we were doing it wrong if the container of the overflowing (monolithic) fragment had more children after the monolithic node, whereas we got it right if it ended in the current fragmentainer. See monolithic-overflow-002.tentative.html vs. monolithic-overflow-003.tentative.html . For flex containers we were already doing it right. For grid containers and tables we were doing it wrong, because we didn't provide a correct intrinsic block-size (which is used by the fragmentation machinery to handle unbreakable content correctly). One additional complication for grid and tables was that we didn't handle the fact that cells or grid items might (now) be stretched by monolithic content, whereas sibling cells / items aren't. So we had to add support for that. Flex layout also already handles this part correctly, in GiveItemsFinalPositionAndSizeForFragmentation(), by compensating for the difference between space consumed by the flex line and the space consumed by the flex item. Do the same for grid and tables. Although this behavior isn't specified, we're now more compatible with Gecko. This behavior also makes more sense. With the previous behavior a child might overflow its container for no reason (the monolithic child would overflow one fragmentainer, whereas the container would fragment at the fragmentation line). This change also makes it much easier to fix crbug.com/1402540 , so that we can just very easily walk past monolithic content that bleeds into subsequent pages. Bug: 1425077, 1378607 Change-Id: I8ebe706b48fa18abb669041843baef74f021a340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370497 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122895}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!