| commit | 155ae72eff461d2dfa02467f7af76c73660add39 | [log] [tgz] |
|---|---|---|
| author | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Apr 03 14:59:41 2023 |
| committer | GitHub <noreply@github.com> | Mon Apr 03 14:59:41 2023 |
| tree | 4f0652cf5df657ef9e80b185f62a27d5814dbf00 | |
| parent | 540f3b210695b9366af12d2e04be6e2a89af10d7 [diff] |
Attempt to move past monolithic content when printing. (#39223) Let monolithic content take up additional space on pages they overflow into, if this prevents content overlap (that wouldn't occur it we weren't paginated). When printing, when we detect that something overflows the page, we'll store this overflow in the break token, so that we can move past it on subsequent pages. This kind of works, because, in our implementation, pages are stacked in the block direction, so that the block-start offset of the next page is the same as the block-end offset of the preceding page. The current solution here only aims to get the basic things right-ish: inside regular block containers, inside floats, and inside out-of-flow positioned elements. In addition, we need to make sure that repeated table headers and footers don't get messed up. We have to repeat those on every page, even if there's monolithic content in the way. In addition to actually (probably) making sense visually, our implementation requires this: once we have decided to repeat a table section, we need to be consistent about it, or the fragment repeated will get upset. For layout systems like flex, grid and tables, we don't attempt to do anything special, for now. This shouldn't cause major problems, but it does mean that content in a flow parallel to the one that has monolithic content (e.g. inside sibling table cells) will be affected (pushed down) by the monolithic content, even if there is no need to do so. Content next to floats with monolithic content inside also doesn't behave correctly. To fix this, we would need to translate and copy the exclusion space from one fragmentainer to another. It should be a rather straight-forward thing to do, but I'd like to see a use-case for it first. Firefox appears to do something very similar, to prevent monolithic overflow from overlapping with subsequent content, with limitations comparable to what this CL does. Bug: 1402540 Change-Id: If2bfec4737ea9ee7169036144f590a913123b6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370688 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1123282} Co-authored-by: Morten Stenshorne <mstensho@chromium.org>
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!