| commit | e16853520ae70ba309108ccff87a7816f74be4dd | [log] [tgz] |
|---|---|---|
| author | David Bokan <bokan@chromium.org> | Tue Jul 18 14:29:04 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jul 18 14:45:41 2023 |
| tree | 0617e0b2e5940dbd3d18f4d965d12bd6170884fd | |
| parent | b4352525758569bd8ba45c294ebd42752bf17bb2 [diff] |
Synthetic gestures only dispatch to visible widget This UAF is caused by a synthetic pointer being routed to browser UI. In this case, it starts dragging a tab which starts a nested message loop Further events and gestures are processed in this nested loop and cleaned up. When the message loop returns the stack contains the cleaned up pointers. Synthetic gestures shouldn't be able to target UI outside the web contents area. The event location is intersected with the web contents' RenderWidget's view bounds to prevent this [1]. However, the bounds will be inaccurate if the widget is in a background tab; it won't receive resizes until it's foregrounded (it's also bad that we can dispatch events to a different tab). This CL fixes the issue by ensuring events are dispatched only to a foregrounded widget. If a synthetic gesture is started while the widget is in a background tab, its start is deferred until it comes into the foreground. If the widget is backgrounded while a gestuere is in progress, the gesture is aborted. Note: we don't do this for DevTools injected events as those skip event routing and go straight to the injecting renderer. The comment in [2] makes me think this is a common use case. [1] https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:content/browser/renderer_host/input/synthetic_gesture_target_base.cc;l=155;drc=ac872e771ce001fef191848bab4167d60dfda403 [2] https://source.chromium.org/chromium/chromium/src/+/refs/heads/main:content/browser/renderer_host/input/synthetic_gesture_target_aura.cc;l=140;drc=ac872e771ce001fef191848bab4167d60dfda403 Bug: 1444597 Change-Id: I2955ce60357f7f03e62f44fd1497bd4ea598f660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4666793 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1171732}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!