commit | b005ebe4cc193b760f439190d7740a2798e22040 | [log] [tgz] |
---|---|---|
author | Ming-Ying Chung <mych@chromium.org> | Wed Aug 16 06:13:18 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Aug 16 06:28:37 2023 |
tree | 95a94ddeb3e438d22f1dee2a50f9816eadda05e7 | |
parent | 0697aa1ea938dd74b1d4f3f69386771cbc64817e [diff] |
[fetch-later] Implement fetchLater API's send-on-context-destroy behavior This CL introduces `FetchManager::DeferredLoader`, which roughly maps to a deferred fetch record[1] in Blink. `FetchManager::Loader` is updated to allow subclass, and to not relying on ScriptPromiseResolver to obtain `ScriptState`, as FetchLater API does not support Promise. Underlying, the DeferredLoader - creates a ResourceRequest with a new flag `is_fetch_later_api` set to true. The flag is piped to network service, to be used in browser. - does not handle any responses. - get disposed on context destroyed, the same as Loader. A DeferredLoader evetually leads to creation of an content::KeepAliveURLLoader in browser (as its keepalive flag is also true), which is updated to support deferred loading behavior with the following extra methods: - KeepAliveURLLoader::IsDeferred() - KeepAliveURLLoader::StartDeferredLoad() KeepAliveURLLoaderService uses the `is_fetch_later_api` flag to tell whether a request should be handled by a deferred KeepAliveURLLoader. If true, the request will only be started when the corresponding mojom::URLLoader is disconnected from a renderer. Design Doc: https://docs.google.com/document/d/1U8XSnICPY3j-fjzG35UVm6zjwL6LvX6ETU3T8WrzLyQ/edit [1]: https://whatpr.org/fetch/1647/094ea69...152d725.html#deferred-fetch-record Bug: 1465781 Change-Id: I6d964d4a55e103cee6ef534f75a8240458ad0127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4756243 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Ming-Ying Chung <mych@chromium.org> Cr-Commit-Position: refs/heads/main@{#1183997}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!