commit | c6e26d40406b88796028c912d3051a869a557647 | [log] [tgz] |
---|---|---|
author | Steinar H Gunderson <sesse@chromium.org> | Tue Sep 05 09:56:33 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Sep 05 10:04:47 2023 |
tree | 69fe0d00c7454c4ea3220278322dabb2ae2accd8 | |
parent | 6e55b885a4e25c2c1c0395e7d3cec4225d595f56 [diff] |
Revert "Reland "Invalidation on stylesheet changes using selector matching"" This reverts commit c125361b2841cfc76a48a91896bc4c049f2ace67. Original change's description: > Reland "Invalidation on stylesheet changes using selector matching" > > This is a reland of commit 5d12010188b8fd648efd2279956e8a6cbe20654e. > The revert has been in for ~6 hours and the tests in question still > fail on the Mac builders, so it's unlikely to be the culprit. > It also passes locally on Mac. > > Original change's description: > > Invalidation on stylesheet changes using selector matching > > > > When inserting, deleting or modifying stylesheets, we need to invalidate > > style for some elements, even though the elements themselves did not > > change. Currently, we reuse the concept of InvalidationSets, which are > > mostly designed for changes to elements, for that. This can sometimes > > cause overbroad invalidations, especially if the style is written in > > a “modern” (read: less-than-ideal) fashion. > > > > We replace this by a somewhat slower but more precise and probably > > simpler system; for each candidate element in the DOM, we see if it > > matches any selectors in the old or the new rulesets (by means of > > the same bucketing logic we currently have during element rule > > collection), and if so, we mark it for style recalc. This isn't perfect; > > if we are e.g. adding a single rule to an existing stylesheet, we would > > still invalidate based on all rules in the sheet. We hope to improve > > this in a future patch, but even now, this shows significant > > improvements over most of blink_perf.css, with only a few regressions. > > > > Note that this means the experimental style invalidation information in > > devtools becomes somewhat less useful; it will no longer give reasons > > for invalidations when style sheets change. Fixing this would probably > > involve extending the protocol, although I haven't looked deeply into > > this. > > > > Bug: 1444522 > > Change-Id: Ib95cf8d215bf4e7b58ab1955ebc1f3c7e31aead8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4783456 > > Commit-Queue: Steinar H Gunderson <sesse@chromium.org> > > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1190433} > > Bug: 1444522 > Change-Id: I522f99ee0fcc59d52d396d92a9af682f6be67a60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4830242 > Commit-Queue: Steinar H Gunderson <sesse@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1190656} Bug: 1478343 Change-Id: I5c463e32f547157b6620cda6f324668f4f46a8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4839258 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192349}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!