commit | 9afcb0cc36b9134bbf04120bb802f2bdb68ae71a | [log] [tgz] |
---|---|---|
author | David Awogbemila <awogbemila@chromium.org> | Thu Sep 07 16:51:44 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Sep 07 17:36:26 2023 |
tree | e1444db5ea3b181718e082f2a8428baaeb57e0be | |
parent | 515554adf1592e8f7bbcd3f9ae4a2925d4f9af2d [diff] |
Choose closest covering position for large snap areas This patch modifies the logic to find snap positions so that when a scroller is scrolled to a position which only partially covers a snap area larger than itself, if it snaps to this large snap area, it snaps to the nearest boundary of that snap area where the snap area covers the snap port, rather than doing a jump to honor the specified scroll-snap-align. Below are a few notes about changes made to tests: snap-area-overflow-boundary.html is corrected so that both test cases correctly verify the scroll offset when snapped to the lower element. The scroll amount in the second test case is also adjusted to ensure it is enough to snap to the lower div. The expectations at the end of scroll-on-large-element-not-covering-snapport.tentative.html are updated to account for choosing a snap position different from the scroll-snap-align-specified position for snap areas larger than their snapports. scroll-snap-type-on-root-element.html is updated to account for scrollbar width since snapping to the right edge of the target is valid. This patch picks new programmatic scroll offsets for snap-to-visible-areas-margin-both.html so that the top-left of intersection of the right-top and left-bottom targets' scroll-margins is closer than the bottom-right of the intersection. scrollend-with-snap-on-fractional-offset.html and scroll-start-with-scroll-snap-tentative.html are adjusted to use snap area sizes that don't cover the snap port. Bug: 1420762 Change-Id: I72d18b8ca44ea5aef015e59b67e4de34a66d8a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4806971 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: David Awogbemila <awogbemila@chromium.org> Cr-Commit-Position: refs/heads/main@{#1193634}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!