commit | 4427c9b02e762e749ee42c51557d722ee2d8e2cd | [log] [tgz] |
---|---|---|
author | David Awogbemila <awogbemila@chromium.org> | Thu Sep 07 23:20:09 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Sep 07 23:36:45 2023 |
tree | 8be0a7c391de85c894c26a8e904f6842a7a5b653 | |
parent | f0df2a4527e5973fab028e047a6202497cc11516 [diff] |
Consider nested snap areas on layout snaps When snapping after a layout change, we snap to the scroll-snap-align-specified position. This may cause unwanted jumps in the case of large snap areas, e.g. when android shows browser controls. For large snap areas (areas larger than the snapport) we should, instead, consider snapping to the closest covering position. This is the behavior for snaps that occur at the end of a scroll. This patch makes snaps after layout changes conform to this behavior. Large snap areas may contain nested snap areas which may themselves be large snap areas that contain nested snap areas, so this patch accounts for this by looking at all snap areas that overlap with the snap area we are attempting to snap to. A few notes about the test changes: snap-area-overflow-boundary.html & changing-scroll-snap-align.html: the first test cases now takes into account that the relayout doesn't reset the scroll position. A test case is also added for changing-scroll-snap-align.html verifying the behavior of small snap targets. Bug: 1467300 Change-Id: I55d3a48838f701ca234cea2eb389daa70aadeacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4842691 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: David Awogbemila <awogbemila@chromium.org> Cr-Commit-Position: refs/heads/main@{#1193830}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!