| commit | 930a749329f30f9a4b8240cff423f5056580b105 | [log] [tgz] |
|---|---|---|
| author | Henrik Boström <hbos@chromium.org> | Wed Sep 13 08:41:06 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Sep 13 08:54:39 2023 |
| tree | 60b78e7c4a299180470178b0502f32d2e7936960 | |
| parent | ccd0bade8d0dbbdf4ce6f06028b2a0e4d194c7de [diff] |
Move dropped frames counters from source to track. If a cloned track has a different FPS than the original track we'll end up with two VideoTrackAdapters with their own instance of the frame decimation algorithm running. This means that a frame that was discarded by one VTA may not be discarded by the other VTA - or it may even be discarded by both VTAs - which all results in MediaStreamVideoSource::OnFrameDropped() independently of other VTAs. This meant that a clone could cause the source discarded counters to go up, which showed up in the original track's getFrameStats() results since both tracks are backed by the same source. To fix this, the track stats are moved from per-source to per-track, specifically to MediaStreamVideoTrack's FrameDeliverer. This means: - All frame counters now live in the same place, on the same thread and map 1:1 to a single track. Simpler and no per-frame PostTask needed. - The code in MediaStreamTrackImpl that was previously needed to convert per-source counters to per-track counters can be deleted. WPT coverage for this is added and other tests moved. # The only bot test failure was unrelated, let's skip the re-run NOTRY=True Bug: chromium:1472978 Change-Id: I6dba739a2a34b1590f54710973eb5af4af470684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4843050 Reviewed-by: Tony Herre <toprice@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#1195869}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!