| commit | b695a020bbedb27f9a304cd4979b97d67bacf353 | [log] [tgz] |
|---|---|---|
| author | Xiaocheng Hu <xiaochengh@chromium.org> | Fri Sep 29 23:12:49 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Sep 29 23:33:38 2023 |
| tree | 7b52fe7d206540b6b4d2dc0e78d4753afa84d94e | |
| parent | a1b7cb7e0099233273cf5acb42e32ac8435efbb5 [diff] |
Reland "[anchor-position] Support margin properties in position fallback" This reverts commit 426a7d8727ff4a2767fdd3cb22b5f091888aa39c. Reason for reland: ensured roundtrip for simple values - Reverted behavior (PS#1): check layout for all boxes - Old behavior (base): check layout for boxes with non-fixed style values - New behavior: check layout for boxes with either non-fixed style values or using position fallback style Original change's description: > Revert "[anchor-position] Support margin properties in position fallback" > > This reverts commit 502912cd04e83f9d1ce1d8df50fc9778b57207e0. > > Reason for revert: causing https://crbug.com/1485377 > > Original change's description: > > [anchor-position] Support margin properties in position fallback > > > > This patch makes margin properties (except margin-trim) allowed in a > > @position-fallback rule, so that different fallback positions can use > > different margins. > > > > There's also some changes to `getComputedStyle()` implementation to > > make it return the used margin values from fallback styles. To do so, > > we unconditionally obtain the result from a `LayoutBox` if the current > > object is a box. Since the result is available only after layout, this > > patch also changes all margin properties on boxes to be layout > > dependent, regardless of the computed margin values. > > > > Note: This causes some rounding differences, as the result from > > `LayoutBox`, which is the actual layout precision, has a fixed-point > > precision of 1/64 px. Therefore, some tests are rebaselined. > > > > Bug: 1475317 > > Change-Id: I4a3e242ceb04413db5348770b5cb666a54a1c9e0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4819910 > > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1190240} > > Bug: 1475317, 1485377 > Change-Id: Ieb200c75919ad7ad67745519791fcb9473c24e9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4881060 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1199388} Bug: 1475317, 1485377 Change-Id: I95789a405a2e1bc71ec3b3819a8bb6c4ddd77ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4885150 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1203515}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!