| commit | 446b9bce1ca9a174c11c64f4faa077a9e9d22e72 | [log] [tgz] |
|---|---|---|
| author | Evan Stade <estade@chromium.org> | Tue Oct 24 18:19:14 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Oct 24 18:51:37 2023 |
| tree | fd32d28946641ce7814d630bd24c615bcaebc3dd | |
| parent | 892583e4adb98da9b63c6ceaf1e0896f2cfb71e7 [diff] |
Deduplicate some WPT. storagemanager-estimate and estimate-indexeddb are more or less the same tests, the latter having been ported from the former to use `async`/`await`. The former probably should have been deleted when the latter was introduced. Since some of the tests are related to IndexedDB and some are not, this change keeps the IndexedDB tests in the file called `estimate-indexeddb` and keeps the basic tests in `storagemanager-estimate` (with minor updates). One wrinkle from the Chromium side is that the behavior of `storageManager.estimate()` is not actually specced, and as the Chromium implementation uses LevelDB, which behaves in mysterious ways, adding things to the database does NOT always increase the reported usage size. Both of these tests operate on large things, which typically do increase usage, however we noticed that for one reason or another, the test that adds an *uninitialized* ArrayBuffer starts failing on Windows if durability is set to relaxed. There are other ways to make the test fail as well: using a shorter name for the database, or putting small values, does not reliably increase the reported usage. This is all fine in the sense that it isn't defined behavior, but it does suggest that working in this area or on tests of this ilk is a bit of a minefield. These tests probably should not exist as WPT, at least not until quota behavior is specced (see https://github.com/whatwg/storage/issues/110). But it would also be sort of a shame to delete WPT that are passing, so I've left them in place for now. Bug: 1489517 Change-Id: I6619f504ce92e428054691ac6bf54a0e14e3ce5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4968659 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/main@{#1214324}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!