| commit | a50aec6c90d6ce28629fa4eb5cbeba0d1d65c53b | [log] [tgz] |
|---|---|---|
| author | Jonathan Lee <jonathan-j-lee@users.noreply.github.com> | Tue Dec 12 01:00:29 2023 |
| committer | GitHub <noreply@github.com> | Tue Dec 12 01:00:29 2023 |
| tree | baf1340895a1e16f094ee7a13dfe7869b642b375 | |
| parent | da76d400793d6eabd61ec0c8b70bb780c2d19fde [diff] |
Revert soft navigation CLs which are causing crashes (#43615)
Revert soft navigation CLs which are causing crashes
This reverts a series of 7 CLs which were causing crashes on both
Canary and Beta channels.
We will follow-up re-enabling these behind a flag, with additional
tests.
Reverts:
* commit bc3a536a4fc930ff5161c7795758e72893b6afca.
"Reland "[soft-navigations] move startTime to processing end""
* commit 6e358318d16c22292d0e57ed7542fe3761c42a72.
"[soft navigations] Ignore non-attributed LCP before softnav detection"
* commit 81fd9fb434f38f1411baae1e30835c21011974e8.
"[soft-navigations] Fix crash when user interaction precedes softnav"
* commit 596e49410759e65ee39d5ffb22f8e4789b5d836b.
"Create ScriptState::Scope in SetCurrentTimeAsStartTime()"
* commit 6039f57d5e4bf6817f6ca4e75ea65e864fcfc2cf.
"Move SoftNavigation end of event emission to a handle based on isolate"
* commit afec46c737c5547302fa35a3944624df44fad755.
"Fix crash by adding v8::HandleScope in SameDocumentCommit"
* commit ad7d9d258f8255f2000cb3cf7a081d1bfe3c3b22.
"Add tests to exercise sync soft navigations paths"
Bug: 1507470, 1508696, 1507981, 1507750, 1505994, 1505059
Change-Id: I2a8283c6958f1cf7724a246ae8026ad6d2300864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5111999
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1235919}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!