| commit | 83b10e015ad6b50100cab9dcca1f60d28eb18ac6 | [log] [tgz] |
|---|---|---|
| author | Masayuki Nakano <masayuki@d-toybox.com> | Wed Dec 13 02:56:16 2023 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Wed Dec 13 10:31:41 2023 |
| tree | 558ae6405ad04988d9d9e98829ddb9ab1c9a2142 | |
| parent | 0a1cec857df3721d249f9ca81b728c53fdfb531d [diff] |
Make `AutoDeleteRangesHandler::ExtendOrShrinkRangeToDelete` not cross flex-item and grid-item boundary The text input of the multi-select combobox of Slack has the following structure: ``` <div contenteditable style="display:flex"> <span class="c-multi_select_input__space"> </span> <span class="c-multi_select_input__filter_query">text which you typed</span> <span class="c-multi_select_input__space" contenteditable="false"> <span> </div> ``` When you do "Select All", they adjust selection to start from start of the text container `<span>` (i.e., `.c-multi_select_input__filter_query`). Then, typing new character deletes selection first. At this time, in the legacy mode, `AutoDeleteRangesHandler::ExtendOrShrinkRangeToDelete` does not extend the deleting range because `<span>` is an inline element. However, in the new mode, it extends the range because the `<span>` is a block since it's a flex-item, and selection starts from current block boundary. Then, deleting range starts before the text container. Finally, Gecko removes the text container and the following non-editable `<span>`. Therefore, typing text will be inserted as a child of the flex container which is the editing host. Finally, Slack restores the previous structure and collapse selection to end of the text. Currently, Chrome does same thing for normal blocks without flex/gird container. However, doing i in `AutoDeleteRangesHandler::ExtendOrShrinkRangeToDelete` causes a lot of regressions. Therefore, this patch tries to avoid only the bug in Slack. (I think that we need to redesign the deletion handler to fix it.) Differential Revision: https://phabricator.services.mozilla.com/D195955 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1868641 gecko-commit: 13548863a72404d66676b9729d9f57f196d2a062 gecko-reviewers: m_kato
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!