commit | 8ac73b1966e968e9224a7869e5d1bf38b0a340cc | [log] [tgz] |
---|---|---|
author | Aaron Leventhal <aleventhal@google.com> | Wed Dec 20 22:42:34 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Dec 20 23:32:49 2023 |
tree | c3fcdf9a5471de820156a7c9ead37802132500dd | |
parent | c84ca70108c0e0b26b731f16a4c2789040db66e4 [diff] |
[A11y] Partial revert to fix crash when finding <option> parent Partial revert of CL:5123413. Remove NOTREACHED() and restore comment. This condition is rare, but can occur if a <select> is inside of a <details> element. When the <select> is first created, there is no layout object, and a generic AXObject (not AXMenuList) is created. The autofill code can call in just at the right time to request this parent, and hits the NOTREACHED(). Test: this crash occurs when loading clock.laplace.live, or by loading the included test in the browser. It's unclear why, but the test does not crash when running as a web test. Note that these AXMenuList* classes will be going away in favor of a generic implementation based on the shadow DOM, using ordinary AXNodeObjects. Fixed: 1512999 Change-Id: I318d6198abc7b155e42030caf00f039c7b09e4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5141647 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1239844}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!