| commit | c635cb4ef1a21ff07e210f2733f97ccb01c0ed15 | [log] [tgz] |
|---|---|---|
| author | Andreu Botella <abotella@igalia.com> | Wed Feb 07 13:40:56 2024 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Feb 07 13:57:36 2024 |
| tree | 04a112dd430f2b3b88246c611cbc3a1221c9108f | |
| parent | aee2a77919002424ba9ef9c302d0716ceff81ea2 [diff] |
Fully implement bidi for a line's trailing spaces (UAX#9 L1) Per UAX#9 L1, any spaces that after line breaking would fall logically at the end of a line must be reset to the paragraph's initial embedding level, regardless of the embedding level of those spaces in the paragraph. Until now, Blink only had partial support for this. The reason this was hard to implement in Blink is because the direction of text is computed in a per-paragraph level, splitting the text into items with a given direction and embedding level. Those items are then split into item results when line breaking, but item results must have the same direction as the item. As part of line breaking, some item results are produced which only have trailing spaces. The partial support, implemented in crrev.com/c/2505486, consisted of marking these results with the `has_only_trailing_spaces` flag, and using this flag to distinguish them when reordering the item results. This patch builds on top of that partial fix by adding a final processing step to line breaking, which splits item results so that trailing spaces (with a different embedding level as the paragraph) are split into its own item result, and by marking all trailing spaces item results as `has_only_trailing_spaces`. This also fixes bug 1514753, where having a item result with non-base direction which had logically trailing spaces was causing the text (rather than the spaces) to hang, because `LineInfo::ComputeTrailingSpaceWidth` assumed that UAX#9 L1 held. This patch also modifies some existing WPT tests to make them use a monospace Arabic webfont (since it's not guaranteed that all OS's have one), and by changing the widths slightly to work around bug 1409445. Bug: 316409, 1514753 Change-Id: I1eb751b457d413b5099dad8f95badba9a1b3e5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5199988 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Cr-Commit-Position: refs/heads/main@{#1257309}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!