| commit | 90cf6d3b851589dea99c460f0aa5e3e9b58f3bbe | [log] [tgz] |
|---|---|---|
| author | Daniil Sakhapov <sakhapov@chromium.org> | Wed May 08 13:23:11 2024 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed May 08 13:34:48 2024 |
| tree | cee5710b7dc4c2ee27d6387305e90f1d6e0287f4 | |
| parent | 7a8b70e636a9556c57fc47e71cae87b4bada3794 [diff] |
Rewrite counters implementation to no cache approach This CL removes the old counters implementation that was building and maintaining a cache of counters (building counters tree). The removal is due to the following reasons: 1) It didn't support Shadow DOM and there was no way to fix it; 2) It didn't work correctly with style containment and there was no way to fix it; 3) It was slow and complicated; 4) It was wrong in many cases. The new approach doesn't build any cache of counters, instead it visits every element on the very first AttachLayoutTree for the document and gathers on the fly all the information it needs to correctly calculate the counters values. It means that we don't have any overhead due to some additional traversals to build the counters cache on the first go. So, all the pages with static (created once and not changed) counters would render faster. If there are some counter changes after the first AttachLayoutTree, we would remember it and then recalculate all counters by doing a full tree traversal, calculating correct counters values and only update LayoutCounters created with counter() and counters() functions. Performance tests held on 300'000 elements with various layouts and various style updates/element insertions/removals show that doing such full tree traversal for counter updates doesn't introduce any noticeable overhead with other browsers (should be noticed that old implementation could also do full tree traversal in some cases). For pages with static counters performance for initial document render is improved around 10 times against the old implementation. Bug: 990657 Change-Id: I292d3749ad0bf480e88d815e9dbecebe9edc7067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483870 Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1298057}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!