commit | 83cff49301dabb7f04195600a65282b1a491ccd0 | [log] [tgz] |
---|---|---|
author | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sun Oct 18 14:32:49 2020 |
committer | GitHub <noreply@github.com> | Sun Oct 18 14:32:49 2020 |
tree | 5cd8edb49cb9696b01a09fb3616894e3544d8a2a | |
parent | ccec5e33e4884f35e897518591db9ca3c0f1f411 [diff] |
MSE-in-Workers: Cross-thread function and tests (#26109) Includes implementation of CrossThreadMediaSourceAttachment (CTMSA) and updates to MediaSource and SourceBuffer to use it. CTMSA owns a lock that it takes on most operations. It also provides a utility method (RunExclusively()), which is used by the MSE API to take that same lock during most operations on the API. The same thread attachment provides a basic version of the same, though no lock is used. CTMSA understands whether or not it is attached, has ever started closing, and whether or not either of the attached contexts has ever destructed. It conditions cross-thread operations to safely behave when one or both contexts is being destructed. MediaSource is given its own small lock that it uses to guard its reference to the attachment instance, when attached. This is required because attachment start is synchronous on the main thread, even if the MediaSource is owned by worker context. CTMSA and MediaSource cooperate to ensure mutex and safety of the two-stage attachment start. In MediaSource::ContextDestroyed(), further care is taken to prevent attachment start success when worker context destruction is possibly racing the main thread's attempt to start attachment. `context_already_destroyed_`, protected by MediaSource's lock, is used to prevent that start from succeeding. MediaSource's context destruction can no longer always assume that accessing the demuxer via the WebMediaSource (and WebSourceBuffers) is safe. The worker version of MediaSource context destruction uses the attachment's RunExclusively() to safely know if it can cleanly Close the underlying demuxer, or if instead it must do a simpler shutdown. Future specification work will likely determine some signal to the media element when the worker-owned MediaSource's context is shutdown, yet the element itself is still alive. For now, sane results are returned by the attachment (nothing buffered nor seekable), with no other error provided. Possible app workarounds might include main and worker watchdogs and being careful about when the main thread explicitly terminates the worker. This experimental implementation attempts to retain BackgroundVideoOptimization, even for MSE-in-Workers, but does not support AudioVideoTracks in the worker MediaSource or SourceBuffer. Plumbing of appropriately-identified track metadata parsed from initialization segment in the worker is used to populate (and remove) media element AudioVideoTracks that should agree with the track id's used internally in WebMediaPlayerImpl to accomplish BackgroundVideoOptimization. As a simplification, CTMSA assumes it can be used for at most one attachment. Effectively, this assumes that the currently on-by-default MediaSourceRevokeObjectURLOnAttach feature behavior will be always-on soon. If CTMSA is not unregistered automatically after successful attachment start (e.g., if that feature is disabled) and if the app attempts to re-use the corresponding object URL for a later attachment, that attachment will be rejected by CTMSA. Note that the same-thread attachment would still allow such re-use when that feature is disabled. Updated web-test: mediasource-worker-attach.html changed to ...-play.html and fixed New web-test: mediasource-worker-play-terminate-worker.html Manual test: page refreshing while running mediasource-worker-play*.html BUG=878133 Change-Id: I21f6542b90d51bdc28096500fb1441d202ab4ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459431 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#818174} Co-authored-by: Matt Wolenetz <wolenetz@chromium.org>
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!