| commit | ca989e9b492ec2da3bd1ec289f529f9ef378c7b5 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Tue Dec 01 11:16:51 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Dec 01 11:35:01 2020 |
| tree | 959e2c05d82b5e5aa6983dfe45a4ffdaa80aff18 | |
| parent | 993ab1ed92b9066fb6d7964948a9ced827b22f36 [diff] |
Stretch column block-size to avoid unappealing breaks.
We do not even attempt to honor orphans or widows requests during the
initial column balancing pass (since we have no idea which column is
going to get which content). Detect unappealing break points during
layout instead, and stretch the columns if possible when this happens.
This is different from the legacy fragmentation engine, which does this
during the initial column balancing pass, but this approach doesn't work
so well, since we'll have no idea which lines end up in the same
fragmentainer, and the lines may have different heights; see
crbug.com/1013151
Also stretch if possible if we violate any
break-{after,before,inside}:avoid rules. Note that it was already
working for break-inside:avoid, but not for break-after or break-before.
css/css-multicol/balance-orphans-widows-000.html also passes without
this fix, but it fails in the legacy engine, due to column
over-stretching described in crbug.com/1013151
css/css-multicol/balance-break-avoidance-000.html also passes without
this fix, but I couldn't find any test like this (break-inside:avoid and
how it affects column balancing), so here it is.
Bug: 1013151, 1066380, 829028
Change-Id: Ic4fca68644864b8209d49fa5f0d62d6079e6c0e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566810
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832279}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!