| commit | 74d5d9577ee54ead71cc051a1467b9eedc341cfb | [log] [tgz] |
|---|---|---|
| author | Aaron Tagliaboschi <aarontag@chromium.org> | Wed Jul 21 22:27:39 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jul 21 23:07:34 2021 |
| tree | cf83f02249523860cc6caebd2d03333e83c6ebba | |
| parent | 297ea5f85e4a95fc2133731ddfdefcb456c469de [diff] |
Turn Critical-CH restarts into internal redirects This fixes a number of issues, including crashes. Unfortunately, this will not fix issues with ACCEPT_CH, which is having a very similar crasher problem. The behaviour is now as follows: if a Critical-CH restart is detected, the Accept-CH preferences are stored as they would be and the ThrottlingURLLoader changes the response to a synthetic redirect. This is registered and takes the response through the normal navigation redirect codepath (which adds the client hints that were stored) and allows extensions, service workers, and other interceptors the chance to handle the new request. The one-redirect limit was also removed and now counts towards the network/navigation redirect limits. Coincidentally, this also runs through the devtools, which makes both the initial and new requests both visible in the Network tab as an internal redirect and regular request. The crashing code is very much NOT fixed by this (see crbug.com/1217589) but rather is side-stepped (instead of restarting the request outright, there's now an internal redirect, which also makes more sense semantically) Also (somewhat coincidentally) fixed an issue with the client hint/service worker WPTs, in that the tests were not waiting for the load event to finish (see the changes in //third_party/blink/web_tests/external/wpt/client-hints/service-workers/resources/util.js) Bug: 1217589, 1228536, 1176879 Change-Id: I8401c67818cdd6cf16a75422b2ba48fe429dc961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983659 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#904079}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!