| commit | 857e496eeb77ab56791de886004e86aa8bbbba08 | [log] [tgz] |
|---|---|---|
| author | Daniel Holbert <dholbert@cs.stanford.edu> | Tue Nov 09 17:46:51 2021 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Wed Nov 10 09:50:29 2021 |
| tree | 84e680d3258376ca5f3392938cd805c8153867a4 | |
| parent | d1dd8e34a4752a6af41ab84d411265ad63c9d2be [diff] |
part 3: Fix mistakes in center-alignment reference-cases in some abspos grid item WPT tests, and mark them as passing. tl;dr: an easy way to verify that this change is correct: the offset for center-alignment must be precisely half of the offset for end-alignment (and it is, after this patch). Some history of these tests & reasoning behind this change: The tests that I'm editing in this patch were all originally written[1] with an assumption that the static positions of abspos grid children should be determined by performing alignment (e.g. centering) inside of the grid container's *padding box*. That is what the spec *used to require*, but that changed -- now the spec says to align within the grid container's *content box*, as discussed in https://bugzilla.mozilla.org/show_bug.cgi?id=1707643#c4 . This bug's previous patch implemented that change, but that wasn't quite enough to make us pass these tests, for reasons described below. Earlier this year, the Chromium folks landed[2] some patches to fix these tests (per the aforementioned spec change), to make the tests expect that alignment happens within the grid's content box. But that fix was incomplete. It correctly updated these tests' .alignEnd cases, to reduce the offsets by 2px (to account for the smaller box that we're doing alignment within); but it did not fix the .alignCenter cases to make a corresponding change there. Really, the .alignCenter cases needed a 1px change to match the .alignEnd cases' 2px change (since a center-alignment offset is exactly half of an end-alignment offset). This patch ties off that loose end by fixing the .alignCenter case in these tests as well. This restores the invariant that the reference cases' .alignCenter offsets are all exactly half of the .alignEnd offsets. [1] in e.g. https://hg.mozilla.org/mozilla-central/rev/ef2f15749bb9#l7.3 [2] in e.g. https://github.com/web-platform-tests/wpt/pull/29435/commits/10a79b147d2d4220d1cf9ccea3920840d7c1f140 Differential Revision: https://phabricator.services.mozilla.com/D130725 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1707643 gecko-commit: cce2b134d29910a624d4972ecd8374c347160058 gecko-reviewers: emilio
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!