| commit | 4a89b60bd822e06cb0e5a2bc6792019ccde05531 | [log] [tgz] |
|---|---|---|
| author | Andreu Botella <abotella@igalia.com> | Mon May 23 10:12:24 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon May 23 10:27:19 2022 |
| tree | a69adda880a3c834352b15433c89dd90b895f612 | |
| parent | 4ee5b8ea5f6af11164acc76ebb83ef4a583a2827 [diff] |
Fix a bug with calculation of ShapeResultView's previous safe offset A ShapeResultView's previous safe to break offset used to be calculated by assuming that a part's first character corresponds to the part's start index. For LTR text, however, the start index is often, if not always, 0, meaning that for ShapeResultViews which start at some non-zero index into the text (such as for lines in a paragraph other than the first), the returned previous safe offset could be much earlier than it should, or it could even be before the start of the view. Since NGLineBreaker::TruncateLineEndResult uses the previous safe offset to determine which parts of a new line to reshape, if the returned safe offset happens to be in the range of the view and in the middle of a ligature, the first character in the ligature would not be reshaped and would thus be set to the ligature glyph, while the characters after the returned safe index would be reshaped and be set to their corresponding glyphs. This leads to the appearence of the characters after the offset being repeated. This was fixed by changing `run_start` to be the part's start index plus the view's char index offset. Bug: 1304876 Change-Id: Ied68dd5986b603814fa236e7ab2081db5a817723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644742 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Andreu Botella <abotella@igalia.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1006370}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!