| commit | 2108f20a92a4073b8a16d00899e976ac3dc48673 | [log] [tgz] |
|---|---|---|
| author | Matt Wolenetz <wolenetz@chromium.org> | Sat Oct 01 01:06:10 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Oct 01 01:18:26 2022 |
| tree | 1922ce0b535fb54a494a6ac6d1a4b78e11755594 | |
| parent | 80e14d03c7a224bcffeda0246d6d20b91e0eb371 [diff] |
MSE-in-Workers: Relaunch with flag guards and handle visibility restricted
This undoes the previous launch revert commit 887a8c4e3d5203b0528e7c911b24be3aa67d2b4e, and includes multiple fixes.
Switches the two RuntimeEnabled features that enable MSE-in-Workers
from experimental to stable status:
MediaSourceInWorkers: Basic support, still using legacy object
URLs for attachment
MediaSourceInWorkersUsingHandle: Upgraded to match updated MSE spec, final PR linked below.
Updates the stable webexposed expectations for both the Main/Window
context and the DedicatedWorker context.
MSE spec PRs with handle usage refinements:
* https://github.com/w3c/media-source/pull/306
* this relaunch also includes implementation of spec fix from
https://github.com/w3c/media-source/pull/317
Intent-to-ship=https://groups.google.com/a/chromium.org/g/blink-dev/c/FRY3F1v6Two
Versus the original launch, this relaunch:
* adds base::Feature (aka flag-guards) for each of the two
RuntimeEnabledFeatures, above (with same feature name strings).
This is to comply with mandatory flag-guarding PSA process update,
and is meant to mitigate possible binary respins in the event this
feature pair yet again needs to be disabled.
* updates the MediaSource.handle attribute getter to fix the
regression responsible for the previous revert, complying with
MSE spec that was fixed to prevent that regression (see PR #317
linked above):
* Removes NotSupportedError exception throwing logic from the
handle attribute getter.
* Restricts visibility of the handle attribute to only dedicated
worker contexts (removes visibility of it from the main/Window
context versus previous launch attempt), along with corresponding
webexposed stable web_tests expectations matching this change.
* Updates mediasource-worker-handle.html web_test to no longer
expect NotSupportedError exception, nor even ability to access the
handle attribute of a MediaSource object on the main/window
context.
BUG=878133
Change-Id: Id34a07254b9b98e79c495429f8ed79555b0c4580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3910706
Commit-Queue: Will Cassella <cassew@chromium.org>
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Will Cassella <cassew@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053854}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!