commit | e490ee0c491a0e84c0dca7886c296d4ff5134a38 | [log] [tgz] |
---|---|---|
author | Masayuki Nakano <masayuki@d-toybox.com> | Fri Nov 11 14:59:54 2022 |
committer | moz-wptsync-bot <wptsync@mozilla.com> | Mon Nov 14 09:56:07 2022 |
tree | 3bfb7b22225e787155ba585a41f18efe1c40b3b7 | |
parent | a4447b9b0f6d7d7080735040223a01b2be5e71f3 [diff] |
Make it work better to activate/inactivate checkboxes and radio buttons like the other browsers First, the test compares `document.querySelector(":active")` and a checkbox or a radio button. However, Gecko activates ancestor elements too. Therefore, Gecko returns `<html>` element or `null` for the selector. However, this is an issue of CSS pseudo class compatibility which is **not** scope of the test. Therefore, this patch makes it compare `document.querySelector("input:active")` and a checkbox or a radio button instead. Next, Gecko does not activate checkboxes and radio buttons when user presses the space key, but the other browsers do it. Therefore, this patch makes `HTMLInputElement::PostHandleEvent` do it and `EventStateManager::PostHandleEvent` clear it at `keyup` of the space key. Next, Gecko does not inactive active elements when it gets lost focus. Therefore, this patch makes `nsFocusManager::NotifyFocusStateChange` do it like the other browsers. Finally, with manual testing of draft patches, I found some issues of inactivating them when they are activated by `<label>`s. Therefore, I add new tests in a separate file. Note that Chrome fails only in the cases testing `<input type="radio">` with `<label>`. Differential Revision: https://phabricator.services.mozilla.com/D160494 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1795620 gecko-commit: e64ab51c2c29192b7880d8fd03acf2313dcf0e8a gecko-reviewers: smaug
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!