| commit | 517c78fb339aa7aa66c3f349dcffcd073e02957a | [log] [tgz] |
|---|---|---|
| author | Jonathan Hao <phao@chromium.org> | Mon Feb 13 11:28:01 2023 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Feb 13 11:49:36 2023 |
| tree | 77fa8827522c428d1043b9d0e68762c9c5830162 | |
| parent | a33eb75d4dcefebc6b65722e0f38fa8a4f72d9f9 [diff] |
[Private Network Access] Do not enforce preflights in http tests The PNA for workers feature are currently in warning only mode, which means that HTTP requests are not blocked, and the following test cases that asserts failures in worker-fetch.window.js and shared-worker-fetch.window.js should not pass: not pass: - private to local: failure - public to local: failure - public to private: failure - treat-as-public to local: failure - treat-as-public to private: failure However, some of these test cases currently pass (meaning fetches failed) because these test cases incorrectly specifies their PreflightBehavior as `success`. In this mode, the test server preflights.py would return 405 when it did not see a preflights before the final request, failing the requests when it shouldn't. This CL adds a mode `optionalSuccess`, which would respond to a preflight if it sees one, but doesn't fail the final request if there isn't a preflight. This allows us to make sure that the requests do fail even if the server responds to preflights. The above applies to virtual/pna-workers-disabled and virtual/plz-dedicated-workers as well. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/fetch/private-network-access/resources/support.sub.js;l=173-175;drc=416bc691f0aab3a1f344b673df60a00b26cd482a;bpv=1;bpt=0 Bug: 1413779 Change-Id: I0a3514b5915e748b07e67a51940937a6befd1f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4231992 Reviewed-by: Yifan Luo <lyf@chromium.org> Commit-Queue: Jonathan Hao <phao@chromium.org> Cr-Commit-Position: refs/heads/main@{#1104426}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!