| commit | 86b4ccd39994c423c55947ffd4dde9dc3d0ce2e2 | [log] [tgz] |
|---|---|---|
| author | Emilio Cobos Álvarez <emilio@crisal.io> | Fri Jul 07 20:32:11 2023 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Fri Jul 07 22:30:11 2023 |
| tree | af7e2aba7d43722e8eecba97f025aeb0596eb97c | |
| parent | 0eed98875a69baa6d0cdabb17ed2840d2a494ad2 [diff] |
Simplify first-line reparenting a bit. The TLDR is that our first-line implementation is complete madness, but I'm not fixing bug 1465474 yet. The guarantee that first-line style reparenting relies on is that reparenting shouldn't change reset properties (that's why we had all this "style to inherit ignoring first-line" to inherit reset properties). Bug 1839223 broke this guarantee in the case the mapped attribute declarations are reused / mutated (which is something we want to do for performance). What's going on in the test-case is that the old style's rule-node declarations are mutated by the mapped attributes code. Re-cascading the old styles yields a different `float` property value. When a style change that causes a reframe like this one happens, we don't update the frame tree styles with the new styles: it'd be wrong and also useless work. First-line reparenting happens after we've recomputed the styles, but before we've reframed as needed. In this intermediate state, the frame remains with the old (floated) style, but the ::first-line reparenting code isn't aware that this frame is going away, so it happily re-cascades and updates the style anyways, creating a floated frame that has float: none in its computed style information. This causes the frame destruction code to crash. This patch restores that guarantee that ::first-line doesn't change reset properties by re-using the "reset properties cache" code-path. This is also simpler since it avoids us having to compute the "parent ignoring ::first-line" style. The code is also more explicit with the new enum rather than just an Option. Differential Revision: https://phabricator.services.mozilla.com/D182769 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1841128 gecko-commit: 43977d30a10af8e193044a9aa578f2bc8b33edf7 gecko-reviewers: TYLin
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!