| commit | eff766e5c8c39be7b9bff064bce3a18eb2953ac5 | [log] [tgz] |
|---|---|---|
| author | Byungwoo Lee <blee@igalia.com> | Sat Jun 19 08:06:36 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Jun 19 08:32:10 2021 |
| tree | 51de7220db8ec53509e0219b9014a53662b6e45f | |
| parent | 4c83511984d28d692a68de2330a844183b9d488e [diff] |
Supports all ':has' relative argument cases Currently the relative selector is not supported yet, so this CL provides the relative argument cases as follows. - :has(:scope > <complex-selector>) - :has(:scope ~ <complex-selector>) - :has(:scope + <complex-selector>) This CL provides a wpt test for the above usage. - has-relative-argument.html While matching those argument selectors on the :has argument subtree of an element, we can get the candidate scope elements. By marking those elements as matched, we can reduce the duplicated ':has' argument matching operation. HasArgumentSubtreeIterator provides the way to traverse the ':has' argument subtree (downward subtree of the :has scope element). The iterator provides right-to-left post-order traversal to prevent incorrect 'NotMatched' status. And it also provides a way to limit traversal depth or adjacent distance to prevent unnecessary tree traversal for direct relations (child/direct sibling). About the issue of incorrect 'NotMatched' status, the previous caching logic has a bug of incorrectly using the cached status to skip one argument selector matching operation for one descendant of an element. The cached status should be used to skip the argument matching operations for all the descendants of an element because it is the status of :has scope element. To store the 'NotMatched' status correctly during the ':has' subtree traversal for argument selector matching , the traversal order should be right-to-left reversed post-order to guarantee that, the downward subtree(descendants/next siblings/descendants of next siblings) of an element was checked with the argument selector before checking the element and the previous check didn't mark the element as 'Matched'. The ':has(.descendant)' test case in the 'has-basic.html' missed to have an expected return value related with this bug, so the test result is fixed with this CL. And to check the added/fixed logic, following test are added. - has-relative-argument.html Change-Id: I71f8752ad90d32c6f9ee6bf87949b838e3843eba Bug: 669058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914967 Commit-Queue: Byungwoo Lee <blee@igalia.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#894067}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!