| commit | 7a0c45dacd346df8cd6dc4e1a040ad8d68526cc7 | [log] [tgz] |
|---|---|---|
| author | Brandon Maslen <brandm@microsoft.com> | Wed Feb 19 01:51:27 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Feb 19 02:21:50 2020 |
| tree | e9660f583c8264614304897f666ac146c93d1259 | |
| parent | a84647ba20e4eb53784f91827b8b74d8512f504c [diff] |
Connect document.requestStorageAccess() to NetworkService This change plumbs successful Document::RequestStorageAccess calls from blink to the RenderFrameHost and subsequently into the BrowserContentClient and CookieManager. This call also ensures that the default StoragePartition in the NetworkService is called to update the set of storage access grants it has. The original callback in the Document is gated upon the successful update of the StoragePartition; this is to ensure no race exists between the renderer process receiving notice of access being granted and the grant(s) actually being delivered to the StoragePartition. Currently only the default partition is signaled to ensure state is not leaked across guest partitions. Future changes will amend the added methods to ensure that new grants are conditionally added to the appropriate CONTENT_SETTINGS_* to persist and that those settings are delivered to the NetworkService CookieManager properly. This change focuses on the proper plumbing and conditional callback when access is requested from a renderer's Document. New mojo methods have been added to the CookieManager and FrameHost interfaces to facilitate updating storage grants and request storage access respectively. As the renderer process may not be trustworthy the FrameHost method is guarded by a feature control check to ensure the feature is actually enabled before allowing the call to proceed. Browser and unit tests have been added to validate newly added surface area and a WPT test case has been added to validate the end to end scenario. In order to facilitate the non-blink feature flag configuration required to run the new test case a virtual test suite `virtual/storage-access-api` has been added to pass the --enable-features=StorageAccessAPI flag to the test binaries. Bug: 989663 Change-Id: Icaf964097f765ae94d4973633a05beb9bdc8c962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833481 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#742422}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!