| commit | 1e107f02690374251a203d4467681393181a3ef9 | [log] [tgz] |
|---|---|---|
| author | Charlie Hu <chenleihu@google.com> | Fri Dec 06 16:31:49 2019 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Dec 06 16:41:02 2019 |
| tree | 64893579426aae2e9ad90b96f1a9dedb6b923dc0 | |
| parent | b512409dff0ac9ca2c96de194bf8b7cd1455840b [diff] |
Fix allow/sandbox attribute timing issue on browser side The issue of allow/sandbox attribute timing originates from bug crbug.com/972089. The initial fix to that bug only deals with feature policy replication problem on renderer side. This CL adds a wpt test that targets a feature(camera) that is tested on browser side. A test on similar issue with sandbox attribute is added as well but as tentative. On browser-side: Frame policy value is captured at RenderFrameHostImpl::BeginNavigation, and travel through the whole navigation process in NavigationRequest::commit_params. Finally it will reach NavigatorImpl::DidNavigate which is called by RenderFrameHostImpl::DidCommitNavigationInternal. NavigatorImpl will then use the value captured from the beginning of navigation in commit_params to set the active frame policy instead of using currently pending frame policy, which could be further modified by the time the navigation commits. This CL also gets rid of separate handling of remote frame container policy in document.cc by capturing pending frame policy at NavigationControllerImpl:: CreateNavigationRequestFromLoadParams. Quick Example: 1. we start on frames A(B), where A applies frame_policy P1 to B. 2. A changes policy to P2. 3. B starts navigation to C. 4. A changes policy to P3. 5. Navigation to C commits. 6. C navigates to D and commits. Previously, we would have committed with policy P3 in both steps 5 and 6. Now, we'll commit with P2 in step 5, and P3 in step 6. Bug: 1012786, 972089, 1026627 Change-Id: Ib944ee204ca82e1ede6052ca58187fe97f0aab00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852905 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#722486}
The web-platform-tests Project is a W3C-coordinated attempt to build a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!