commit | 491cd874e7bb2487829f83df8b25b2b70b4c5e22 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Tue Nov 12 15:59:30 2019 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 12 16:43:29 2019 |
tree | 5bbe48c9cb21095c174547d275ced96b292bfdcc | |
parent | a1be16d3d955a0dc8f71e259c54b2afd54725355 [diff] |
[LayoutNGFragmentPaint] Fix containing-block of OOF-positioned objects. We had an issue in the existing invalidation code when an object could contain an OOF-positioned node, but wasn't a LayoutBlock. This already happens when we have a LayoutInline being a containing-block, but there are other cases where this is true. Clusterfuzz found that LayoutTableSection falls into this category. E.g. The OOF-positioned node would be inserted into the nearest containing-block (the anonymous LayoutTable in this case). When it stopped being a containing-block, the OOF-positioned node was never removed from the LayoutTable. This caused a crash when the OOF's layout was invalidated. The OOF marked itself, and the LayoutView (its new containing block) for layout. But the LayoutView didn't know it had this as an OOF-positioned child. This patch moves the current logic within LayoutBlock into LayoutBoxModelObject. Bug: 1021491, 1021676, 1022545 Change-Id: I0f0b4c8aa655fc7edca5d79379205a8d445713d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906708 Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#714487}
The web-platform-tests Project is a W3C-coordinated attempt to build a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!