| commit | 80b2a8f11ace6b83ad7c4ef0d43ff5cdaf2df864 | [log] [tgz] |
|---|---|---|
| author | moz-wptsync-bot <wptsync@mozilla.com> | Mon Dec 16 17:52:19 2019 |
| committer | jgraham <james@hoppipolla.co.uk> | Mon Dec 16 17:52:19 2019 |
| tree | 0b3463fa612bfd82b2d27e275d9f0eb028b7bafa | |
| parent | d650719426a202f19db88dfda730f23e7fd03e82 [diff] |
[Gecko Bug 1592781] use promise_test() to schedule TaskRunner Tasks (#20610) promise_test() provides that a subtest is generated for each Task and run even when an exception is thrown while running a previous Task. This change also provides that Tasks that do not complete are reported TIMEOUT, andTasks that are not reached due to TIMEOUT in a previous test are reported NOTRUN. The previous logic in Task.run() to generate a subtest for reporting a PASS after calling _taskFunction() had a flaw that calls to done() during _taskFunction() would synchronously call _testharnessDone() before the subtest was generated. Differential Revision: https://phabricator.services.mozilla.com/D51563 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1592781 gecko-commit: 195a6104b5fdd7b3f9d04d1ce8e0e86bdbb29869 gecko-integration-branch: central gecko-reviewers: jgraham * catch unhandled rejections in async TaskRunner Tasks Unhandled rejections are then reported against the appropriate subtest. Differential Revision: https://phabricator.services.mozilla.com/D51564 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1592781 gecko-commit: 98ce0aadba7a30c5ca695468bf8561d1c911b038 gecko-integration-branch: central gecko-reviewers: jgraham * use existing promise test instead of separate subtest for step_timeout() Depends on D51564 Differential Revision: https://phabricator.services.mozilla.com/D51565 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1592781 gecko-commit: 2d26bfe54d3fabcd4aabe257cbf9bb5c1cf9fd27 gecko-integration-branch: central gecko-reviewers: jgraham * assert that task.done() is called once only Depends on D51565 Differential Revision: https://phabricator.services.mozilla.com/D51566 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1592781 gecko-commit: 4f9bb3fd99208bbf178a0e2623faaf05eee18a02 gecko-integration-branch: central gecko-reviewers: jgraham * auto-finish TaskRunner Tasks created from async functions Differential Revision: https://phabricator.services.mozilla.com/D51567 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1592781 gecko-commit: 8ac99aff562c3065c7ad806e4ee54f1f85134668 gecko-integration-branch: central gecko-reviewers: jgraham * remove now-unused _logException() as in https://hg.mozilla.org/mozilla-central/rev/195a6104b5fd#l9.2 When the Gecko changeset was merged for a wpt PR in 31759598c118f71bdb54cc72a80b484f58e36d8c there was no _logException() function to remove, as this was added in f3ef5f04bd2bb18ce426ef703f066aaa1078e492.
The web-platform-tests Project is a W3C-coordinated attempt to build a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!