commit | 2cb652e543d379bafcb3d0d26e2de28836f22df4 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Fri Dec 20 14:37:41 2019 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Dec 20 18:30:18 2019 |
tree | 10996add7166cba3e9fd5593ab1cd3b36bd0e11b | |
parent | 80e94e6d5113f3670e0b36c0a1fd905a43ce65d5 [diff] |
[css-pseudo] Properly set 'display: inline-block' to outside ::marker Before this patch, outside markers were assigned 'display: inline-block' but this happened in two different places: in LayoutNGListItem for markers with 'content: normal', and in StyleAdjuster for content ones. However, this meant that 'getComputedStyle(el, "::marker").display' would be 'inline' in the former case and 'inline-block' in the latter. This patch fixes that issue by ensuring that StyleAdjuster runs for all markers, assigning 'display: inline-block' to outside ones even when 'content: normal'. This has a noticeable effect even if the CSSMarkerPseudoElement flag is disabled: text decorations are no longer propagated to outside markers. This is actually expected, since decorations shouldn't be propagated to inline-block descendants. They were being propagated for markers with 'content: normal' because the code that stops the propagation either wasn't running for unstyled markers, or for styled normal markers it was running before 'display: inline-block' was assigned. This change won't be a compat problem since none of Chromium legacy, Firefox and Edge propagate text decorations to outside markers by default. Doing it seemed a LayoutNG bug. Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo Spec: https://drafts.csswg.org/css-lists/#list-style-position Spec: https://drafts.csswg.org/css-text-decor-4/#line-decoration BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-016.html TEST=external/wpt/css/css-pseudo/marker-display-computed.html The marker-content-016 test fails in legacy since the 'content' property is not supported yet in ::marker Change-Id: Ia1396a4f6c5d9825dba5a6265c32096a7066fbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975887 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#726783}
The web-platform-tests Project is a W3C-coordinated attempt to build a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!