| commit | fc3176488617ee61185894aa32fd339f7b87156b | [log] [tgz] |
|---|---|---|
| author | Samael Wang <freesamael@gmail.com> | Tue Jan 14 14:57:41 2020 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Tue Jan 14 22:45:22 2020 |
| tree | 3923ccdba6d7fe2a6b0be576f585ec03bc334ee4 | |
| parent | 8d7a2ceb15083bd05d1aa0d9ad0ce3a5d2499af1 [diff] |
Part 2: Replace inapplicable tests with a web-platform-test for reloading after setting javascript: URI, and fix other tests relying on javascript: URI. Some notes about the changes: Both test_bug384014.html and test_bug123696.html were testing reloading of javascript: URI. The expected result of the iframes after reloading would become about:blank. I deleted both file and instead wrote with web-platform-test to cover reloading of javascript: URI since wpt is more preferable. storage-cache-error.html was utilizing javascript: URI to test bug 1262766. javascript: URI would cause CacheStorage::Keys to throw a dom security exception because the URI's principal (which did not match the principal of the document in this case!) was a nullpricipal. With my patches the iframe's URL would no longer be the javascript: URI, so it's no longer applicable for the test case. Instead we can test what bug 1262766 was originally about - that CacheStorage::Keys would throw a dom security exception if it's in a private browsing window. Differential Revision: https://phabricator.services.mozilla.com/D59465 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=836567 gecko-commit: 68447a9ccb6afbde6bf3817c72bae89a5f7d242d gecko-integration-branch: autoland gecko-reviewers: Gijs, miker
The web-platform-tests Project is a W3C-coordinated attempt to build a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!