| commit | 356d408e111154724d2b65234342c91575d89e44 | [log] [tgz] |
|---|---|---|
| author | Boris Zbarsky <bzbarsky@mit.edu> | Wed Jan 22 16:57:30 2020 |
| committer | jgraham <james@hoppipolla.co.uk> | Thu Jan 23 15:28:27 2020 |
| tree | 43ae8eb5ff4f17c9d8e9ffa61a6c5c4104599801 | |
| parent | 8830b26d8349db61642b662fe30c178197c508ea [diff] |
part 2. Throw the right exception when a user.id value is too long.
The test changes are for the following reasons:
1) Removing the "empty ArrayBuffer" test: I don't see anything obvious in the
spec that would cause that to reject before prompting the user, and in fact it
does not do that in browsers. All browsers time out on that line.
2) Removing the "name is object" test: This test is wrong. Passing {} where a
string is expected in IDL will come out as the string "[object Object]" on the
other side, and that seems like a perfectly valid name.
3) Removing the "name is null" test: This test is wrong. Passing null where a
string is expected in IDL will come out as the string "null" on the other side,
and that seems like a perfectly valid name.
4) Removing the "name is empty" test: I don't see anything obvious in the
spec that would cause that to reject before prompting the user.
5) Removing the various "icon is whatever" tests: I don't see anything obvious in the
spec that would cause that to reject before prompting the user.
6) Removing the various "displayName is whatever" tests: the same reasoning as
for the coresponding "name is whatever" tests applies.
Differential Revision: https://phabricator.services.mozilla.com/D60685
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1610732
gecko-commit: 274fbf05b89544ac4e006a881cf4093afecbb75e
gecko-integration-branch: autoland
gecko-reviewers: jcj
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!