| commit | 0e615f38afaa95df7f5b410508f4eec4d155d6ed | [log] [tgz] |
|---|---|---|
| author | Yu Han <yuzhehan@chromium.org> | Tue Feb 11 19:43:39 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Feb 11 20:12:25 2020 |
| tree | 20a9322f749ed80529a1bee3d6b73b23c0d1459e | |
| parent | 476861eef732bcb4c70473f66aac8b43f7bbb43f [diff] |
Reland "Fixes click on inline element embedded in anchor inside <summary> breaks anchor."
This reverts commit b4cb14f3cacece63ea28e9a021a77c41867e0503.
Reason for revert: Getting ready to re-land
The original fix for Bug: 538283 introduced a regression, Bug: 1045433.
So it was reverted. This is another fix for the original issue and
ensures anchor behavior does not regressed.
To recap, the original issue is caused by DOMActivate event generated
from inline elements. DOMActivate bypasses anchor, bubbles up to
<summary>, and gets handled. The underlying event, click, stops
propagating and terminates. The original fix for anchor looks at the
underlying event and handles it if it's click. However, this logic is
wrong because the anchor can preemptively handle a click that
belongs to another element earlier in the event path.
This example, in file label-inside-anchor.html, illustrate the problem.
<a href="javascript:void(0)" target="_blank">
<label for="peas"><span id="text">peas?</span></label>
<input type="checkbox" name="peas" id="peas">
</a>
Clicking on 'text' generates DOMActivate, which is handled by <a>.
Prior to my original fix, DOMActivate isn't handled, and click event
bubbles up until it's handle by the <label> attribute. Bug: 1045433 is
another example of the same behavior. Video element wrapped by anchor.
In this fix, summary element uses the Node property
HasActivationBehavior and does not handle DOMActivate if the target
node or any of its ancestors up itself has this property set. This
allows the click event to continue propagating until it gets handled
by an node with ActivationBehavior.
Original change's description:
> Revert "Fixes click on inline element embedded in anchor inside <summary> breaks anchor."
>
> This reverts commit 4eb4df63f17ee0f22cd17472fa6ae92311e49900.
>
> Reason for revert: Caused crbug.com/1045433.
>
> Original change's description:
> > Fixes click on inline element embedded in anchor inside <summary> breaks anchor.
> >
> > Previous to this CL, clicking on an inline element embedded in an anchor placed
> > inside a <summary> tag will expand the <details> section instead of navigating to
> > the anchor's href. However, when the anchor is placed outside of <summary>,
> > it behaves correctly.
> >
> > The error is caused by DOMActivate event generated by the inline element. As
> > DOMActivate bubbles up, it bypasses the anchor's event handler, reaches the
> > <summary>, and is handled there. Once DOMActivate is handled, the original
> > click event stops propagating and terminates. This behavior, however, differs
> > from when the anchor tag is placed outside of the summary. DOMActivate isn't
> > handled, and the original click event keeps bubbling up till it's handled by
> > the anchor.
> >
> > DOMActivate event is deprecated:
> > https://developer.mozilla.org/en-US/docs/Web/API/Element/DOMActivate_event.
> > However, since blink still has code that depends on it, replacing it is outside
> > of the scope for this fix. Instead, this fix is for the anchor element to
> > handle the DOMActivate event as it bubbles up. The anchor event handler checks
> > the underlying event of DOMActivate and handles it if it's a click.
> >
> > I also looked at an alternative fix by trying to prevent the DOMActivate event
> > from bubbling up. But calling event.stopPropagation() doesn't work as the
> > EventDispatcher::DispatchEventPostProcess doesn't check this status.
> >
> >
> > Bug: 538283
> > Change-Id: I11fb072faa0563279d43a28e5dc19cee89906bf0
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928234
> > Reviewed-by: Kent Tamura <tkent@chromium.org>
> > Reviewed-by: Mason Freed <masonfreed@chromium.org>
> > Commit-Queue: Yu Han <yuzhehan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#718552}
>>
> Bug: 1045433
> Change-Id: I14b369beb04171ef846cb3a79ebb3fe268cf5c89
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023267
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735575}
Bug: 1045433
Change-Id: I0cdd7b48a2c4e9bf2b653edef9ce7970d7e64938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028455
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740380}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!