commit | 5da9ebc80b58ccd9abe5c2022fc659e645466314 | [log] [tgz] |
---|---|---|
author | Carlos Alberto Lopez Perez <clopez@igalia.com> | Tue Feb 11 19:11:11 2020 |
committer | GitHub <noreply@github.com> | Tue Feb 11 19:11:11 2020 |
tree | 46f6210240884cb19b9de453c7094365e5262031 | |
parent | 23ee655e646454469a5ee0ca2758fa8544053ca7 [diff] |
Fix is_alive() usage and always called it as a function. (#21704) There is some confusion in the way the method is_alive is used. The code seems to assume that this method is accessed like a variable for Protocol and WebDriverServer classes (by using the @property decorator in the is_alive() definition). But then some class that inherit from those and re-declare is_alive() forget to declare the decorator. For example, the base class Protocol declares is_alive as a property, but some of the classes that inherit from it like WebDriverProtocol from executorwebdriver.py, ServoWebDriverProtocol or SeleniumProtocol. This caused the code that checks for is_alive to be broken for those classes because "if is_alive" its always true. To add to the confusion about how this should be used, the browser classes have also a method named is_alive(), where the current code assumes it is used as a function. This has already caused previously confusion (see 8be26a07bc). Fix this by ensuring is_alive() its always used as a function and remove the @property decorators from the classes that were declaring it.
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!