| commit | 120b11e0f17b600e5edb0089eeca4ca0258fde43 | [log] [tgz] |
|---|---|---|
| author | Hiroki Nakagawa <nhiroki@chromium.org> | Thu Feb 27 08:41:30 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 27 09:03:26 2020 |
| tree | fb7ba5ff1675897d71c68bc5bf11d845c90185af | |
| parent | 1a7f5f868420607ef13a00c6ec14fd9e0310e7c0 [diff] |
Worker: Add tests for worker creation in data URL iframe and dedicated worker
This CL adds tests for dedicated/shared worker creation in data URL
contexts (iframe and dedicated worker) whose origins are opaque.
For dedicated worker creation:
1. Creating a dedicated worker in a data URL iframe
2. Creating a dedicated worker in a data URL dedicated worker
3. Creating a data URL dedicated worker in a data URL iframe
4. Creating a data URL dedicated worker in a data URL dedicated worker
Expected behavior:
- For 1 and 2, they are expected to asynchronously fail worker
construction because the same-origin policy is supposed to be
checked during the fetch algorithm based on request's "same-origin"
mode.
- For 3 and 4, they are expected to succeed in worker construction
because fetching a data URL from a data URL context is allowed.
Chrome behavior
- For 1 and 2, Chrome synchronously fails the cases because the
same-origin policy is checked in the Worker constructor (i.e.,
SecurityOrigin::CanReadContent() call in
AbstractWorker::ResolveURL()). See issue 1055697.
For shared workers:
5. Creating a shared worker in a data URL iframe
6. Creating a data URL shared worker in a data URL iframe
Expected behavior:
- For 5, this is expected to asynchronously fail worker construction
because the same-origin policy is supposed to be checked during the
fetch algorithm based on request's "same-origin" mode.
- For 6, this is expected to succeed in worker construction because
fetching a data URL from a data URL context is allowed.
Chrome behavior
- For 5, Chrome synchronously fails worker construction because the
same-origin policy is checked in the SharedWorker constructor. This
is the same as 1 and 2. See Chrome behavior for 1 and 2.
- For 6, Chrome synchronously fails worker construction because of
issue 1055693.
Chrome doesn't support creating shared workers in dedicated workers and
vice versa, so this CL doesn't contain those cases. Note that these are
allowed in the HTML spec, so it would be nice to have WPTs for the
cases, but it's out of the scope of this CL.
Bug: 1053382, 1055693, 1055697
Change-Id: I8480b6079d4fb271855656cedcffc86e6e6c0fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043533
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744973}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!