commit | 06114b9ab7eb85376ce6a1982fb850ba8c5c60ef | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Wed Feb 26 13:47:11 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Feb 26 14:12:49 2020 |
tree | b5cf4595769a1089a06eff666bb67d049dfcd430 | |
parent | 80dba3dde315e0b1292903337d78f5bd95d2e446 [diff] |
Perform kNotInsideLink-related adjustments in ElementRuleCollector The link_match_type stored on the MatchedProperties object is only relevant and correct if we're inside a link, hence we need to override the effective link_match_type at some point. Previously, we would do this apply-time, and not as part of the rule- collection. This CL instead proposes that ElementRuleCollector take the link-status into account, and perform the adjustment before storing the link_match_type on MatchedProperties, such that no further adjustments are required later. This fixes a bug in the CSSCascade path, where we would incorrectly not apply anything for selectors such as *:not(:link):not(:visited), even for elements that are not inside links. (See AddLinkFilter in cascade_expansion.cc. We would switch on the value 0, and then enter the default case, causing a filter to be added on kProperty, which causes all properties to be rejected. This is correct for elements that are inside links, but not for elements that aren't). Bug: 1055715 Change-Id: I2b63de41753fb0fa7b637a4be5bd009c2f165fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072223 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#744631}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!