[css-grid] Fix referencing line both inside and after auto repeat()

When referencing a line name appearing both inside and after an auto
repeat(), the code used to just take the minim of:
 - The absolute index of the line inside the auto repeat(), i.e. the
   local index relative to the auto repeat() plus the insertion point of
   the auto repeat().
 - The index of the line outside the auto repeat(), without expanding
   repeated tracks.

This was correct if the line outside the auto repeat() preceded it.
Otherwise it was wrong due to not taking repeated tracks into account.

For example, with

  grid-template-columns: 1px repeat(auto-fill, 2px 3px [a]) [a];

the absolute index of the line inside the auto repeat() is 2 + 1 = 3.
And the absolute index of the line outside the auto repeat() is 1 + 2*n.
However, the used index wasn't including repeated tracks so it was 2.

Therefore, the minimum was 2 but should have been 3.

BUG=966090

TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-003.html

Change-Id: I1777a64d7e7d39350a327185dcd13f82493adfdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071019
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#745925}
1 file changed
tree: 5bae633f416e74f4aa350c4d27c4a543d114e594
  1. .github/
  2. .well-known/
  3. 2dcontext/
  4. accelerometer/
  5. accname/
  6. acid/
  7. ambient-light/
  8. animation-worklet/
  9. annotation-model/
  10. annotation-protocol/
  11. annotation-vocab/
  12. apng/
  13. appmanifest/
  14. audio-output/
  15. background-fetch/
  16. BackgroundSync/
  17. badging/
  18. battery-status/
  19. beacon/
  20. bluetooth/
  21. clear-site-data/
  22. client-hints/
  23. clipboard-apis/
  24. common/
  25. compat/
  26. compression/
  27. conformance-checkers/
  28. console/
  29. contacts/
  30. content-dpr/
  31. content-security-policy/
  32. cookie-store/
  33. cookies/
  34. core-aam/
  35. cors/
  36. credential-management/
  37. css/
  38. custom-elements/
  39. device-memory/
  40. docs/
  41. document-policy/
  42. dom/
  43. domparsing/
  44. domxpath/
  45. dpub-aam/
  46. dpub-aria/
  47. editing/
  48. element-timing/
  49. encoding/
  50. encoding-detection/
  51. encrypted-media/
  52. entries-api/
  53. event-timing/
  54. eventsource/
  55. feature-policy/
  56. fetch/
  57. FileAPI/
  58. fonts/
  59. forced-colors-mode/
  60. fullscreen/
  61. gamepad/
  62. generic-sensor/
  63. geolocation-API/
  64. geolocation-sensor/
  65. graphics-aam/
  66. gyroscope/
  67. hr-time/
  68. html/
  69. html-longdesc/
  70. html-media-capture/
  71. idle-detection/
  72. imagebitmap-renderingcontext/
  73. images/
  74. import-maps/
  75. IndexedDB/
  76. inert/
  77. infrastructure/
  78. input-device-capabilities/
  79. input-events/
  80. installedapp/
  81. interfaces/
  82. intersection-observer/
  83. js/
  84. js-self-profiling/
  85. keyboard-lock/
  86. keyboard-map/
  87. kv-storage/
  88. largest-contentful-paint/
  89. layout-instability/
  90. lifecycle/
  91. loading/
  92. longtask-timing/
  93. magnetometer/
  94. mathml/
  95. measure-memory/
  96. media/
  97. media-capabilities/
  98. media-playback-quality/
  99. media-source/
  100. mediacapture-depth/
  101. mediacapture-fromelement/
  102. mediacapture-image/
  103. mediacapture-record/
  104. mediacapture-streams/
  105. mediasession/
  106. mimesniff/
  107. mixed-content/
  108. mst-content-hint/
  109. native-file-system/
  110. navigation-timing/
  111. netinfo/
  112. network-error-logging/
  113. notifications/
  114. offscreen-canvas/
  115. old-tests/
  116. orientation-event/
  117. orientation-sensor/
  118. origin-policy/
  119. page-visibility/
  120. paint-timing/
  121. payment-handler/
  122. payment-method-basic-card/
  123. payment-method-id/
  124. payment-request/
  125. performance-timeline/
  126. PeriodicBackgroundSync/
  127. permissions/
  128. permissions-request/
  129. permissions-revoke/
  130. picture-in-picture/
  131. pointerevents/
  132. pointerlock/
  133. portals/
  134. preload/
  135. presentation-api/
  136. printing/
  137. priority-hints/
  138. proximity/
  139. push-api/
  140. quirks/
  141. referrer-policy/
  142. remote-playback/
  143. reporting/
  144. requestidlecallback/
  145. resize-observer/
  146. resource-timing/
  147. resources/
  148. screen-capture/
  149. screen-orientation/
  150. screen_enumeration/
  151. scroll-animations/
  152. scroll-to-text-fragment/
  153. secure-contexts/
  154. selection/
  155. serial/
  156. server-timing/
  157. service-workers/
  158. shadow-dom/
  159. shape-detection/
  160. signed-exchange/
  161. sms/
  162. speech-api/
  163. storage/
  164. storage-access-api/
  165. streams/
  166. subresource-integrity/
  167. svg/
  168. svg-aam/
  169. timing-entrytypes-registry/
  170. tools/
  171. touch-events/
  172. trusted-types/
  173. uievents/
  174. upgrade-insecure-requests/
  175. url/
  176. user-timing/
  177. vibration/
  178. video-raf/
  179. visual-viewport/
  180. wai-aria/
  181. wake-lock/
  182. wasm/
  183. web-animations/
  184. web-bundle/
  185. web-locks/
  186. web-nfc/
  187. web-share/
  188. webaudio/
  189. webauthn/
  190. WebCryptoAPI/
  191. webdriver/
  192. webgl/
  193. webgpu/
  194. WebIDL/
  195. webmessaging/
  196. webmidi/
  197. webrtc/
  198. webrtc-extensions/
  199. webrtc-identity/
  200. webrtc-quic/
  201. webrtc-stats/
  202. webrtc-svc/
  203. websockets/
  204. webstorage/
  205. webusb/
  206. webvr/
  207. webvtt/
  208. webxr/
  209. workers/
  210. worklets/
  211. x-frame-options/
  212. xhr/
  213. xslt/
  214. .azure-pipelines.yml
  215. .codecov.yml
  216. .gitattributes
  217. .gitignore
  218. .mailmap
  219. .pyup.yml
  220. .taskcluster.yml
  221. CODEOWNERS
  222. CONTRIBUTING.md
  223. LICENSE.md
  224. lint.whitelist
  225. README.md
  226. testharness_runner.html
  227. update-built-tests.sh
  228. wpt
  229. wpt.py
README.md

The web-platform-tests Project

Taskcluster CI Status

The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.

The most important sources of information and activity are:

  • github.com/web-platform-tests/wpt: the canonical location of the project's source code revision history and the discussion forum for changes to the code
  • web-platform-tests.org: the documentation website; details how to set up the project, how to write tests, how to give and receive peer review, how to serve as an administrator, and more
  • wpt.live: a public deployment of the test suite, allowing anyone to run the tests by visiting from an Internet-enabled browser of their choice
  • wpt.fyi: an archive of test results collected from an array of web browsers on a regular basis
  • Real-time chat room: the IRC chat room named #testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived here
  • Mailing list: a public and low-traffic discussion list
  • RFCs: a repo for requesting comments on substantial changes that would impact other stakeholders or users; people who work on WPT infra are encouraged to watch the repo.

If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.

Setting Up the Repo

Clone or otherwise get https://github.com/web-platform-tests/wpt.

Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).

Running the Tests

See the documentation website and in particular the system setup for running tests locally.

Command Line Tools

The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:

  • wpt serve - For starting the wpt http server
  • wpt run - For running tests in a browser
  • wpt lint - For running the lint against all tests
  • wpt manifest - For updating or generating a MANIFEST.json test manifest
  • wpt install - For installing the latest release of a browser or webdriver server on the local machine.

Windows Notes

On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).

python wpt [command]

Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.

Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.

Publication

The master branch is automatically synced to http://w3c-test.org/.

Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.

Branches

In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.

Contributing

Save the Web, Write Some Tests!

Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.

The way to contribute is just as usual:

  • Fork this repository (and make sure you're still relatively in sync with it if you forked a while ago).
  • Create a branch for your changes: git checkout -b topic.
  • Make your changes.
  • Run ./wpt lint as described above.
  • Commit locally and push that to your repo.
  • Create a pull request based on the above.

Issues with web-platform-tests

If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!