commit 4d00984a61358a8c3a743f60cb49ccc1ccffeae4
author Delan Azabani <dazabani@igalia.com> Tue Mar 17 15:29:43 2020
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Tue Mar 17 16:00:54 2020
tree e2e2ab3b6d48cd77b930568e7b0aa2638303face
parent d10a20b00ebdc75b0afe454b9e6300f41f6cf169

Migrate DeprecatedEqual to EqualASCII for HTML attribute values

DeprecatedEqualIgnoringCase (“DeprecatedEqual”) returns true iff the
two given strings are equal under non-Turkic case folding (full iff
both strings are 16-bit, simple otherwise).

DeprecatedEqual was deprecated in favour of EqualIgnoringASCIICase or
EqualIgnoringUnicodeCase [1]. The former is usually the appropriate
choice for web platform features that need to check for equality with
a constant keyword.

This CL migrates a significant subset of DeprecatedEqual calls: those
where one of the arguments is an 8-bit literal, containing only ASCII,
defined (or ought to be defined) somewhere in the HTML specification.

Unlike the last three patches against the same bug, these changes come
with web platform tests. This is because they’re author-facing and the
values contain the letter “s”, one of the four ASCII characters whose
equivalence class would change when switching from simple non-Turkic
case folding to ASCII insensitivity [2].

The engine changes are a curated subset of the following replacement
under Sublime Text 2 (PCRE):

Find:           (?x-i)
                (?<escape>\\['"?\\abfnrtv]){0}
                (?<literal>"(?:(?=[ -~])[^"]|(?&escape))*"){0}
                (?<any>(?:[^(),]|(\((?:[^()]*|(?-1))\)))*+){0}
                DeprecatedEqualIgnoringCase
                (\s*\(\s*+(?:
                    (?&literal)\s*,\s*+(?&any)
                    |(?&any)\s*,\s*+(?&literal)
                )\s*\))
Where:          *.cc,-/path/to/src/out/*,-/path/to/src/.clangd/*
Replace:        EqualIgnoringASCIICase$5

[1] https://codereview.chromium.org/2811793004/patch/1/10109
[2] https://www.unicode.org/Public/UCD/latest/ucd/CaseFolding.txt

Bug: 627682
Change-Id: I5f4279a3f6957d3604357df5da7c67ff2bdcdb1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032655
Commit-Queue: Delan Azabani <dazabani@igalia.com>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750965}