| commit | 48f8659c8f7f63c7e70ae02da89df0524ff52f0c | [log] [tgz] |
|---|---|---|
| author | Victor Costan <pwnall@chromium.org> | Wed Mar 25 19:55:25 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Mar 25 20:17:13 2020 |
| tree | b2e9c65c89c0cdddecaeb8d0d02dcf20b04898ea | |
| parent | cc7aa411108eaa975bc9b7faabe6801c714c8595 [diff] |
NativeIO: Plumbing and minimal functionality. This is a scaffolding CL for NativeIO, a.k.a. Low-Level Storage. Most details will probably change over time, but the overall architecture is intended to be stable. To facilitate review, this CL aims to introduce enough aspects of the API for readers to reason about IPC security and general architectural concerns in the browser and in Blink. The summary below is also intended to facilitate review. * NativeIO introduces new per-origin storage. The per-origin model matches other existing storage APIs, so no new permissions are added. * NativeIO storage is structured as files in a flat per-origin namespace. Files are stored in a per-origin directory under the user's profile. * The browser-side implementation enforces access control at the file level. Once a renderer is allowed to open a file, the browser passes the file descriptor to the renderer. This approach aims to minimize the latency of I/O operations. * The renderer exposes two API flavors to web pages -- an asynchronous version and a synchronous version. The latter is only available in dedicated workers. The goal is to allow developers to experiment with both flavors of the API, and report back on performance and stability. * In the asynchronous API, all file I/O is done on tasks posted to Blink's worker thread pool. This avoids jank on the main thread, at the cost of two thread hops per I/O operation. This CL adds two READMEs with some minimal information. * //third_party/blink/renderer/modules/native_io/README.md * //third_party/blink/web_tests/external/wpt/native-io/README.md An API explainer is available at https://github.com/fivedots/nativeio-explainer Binary-Size: New Web Platform feature. Fugu P1. Bug: 914488 Change-Id: I2c8c794837c5332d81bfbab2ed0827e1f26f7cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093918 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#753327}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!