| commit | 4b3fd166980ee106af2db6ca6a8c653fb07a517c | [log] [tgz] |
|---|---|---|
| author | Xianzhu Wang <wangxianzhu@chromium.org> | Wed May 06 22:07:19 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed May 06 22:44:23 2020 |
| tree | b9ddd3095318df2c428b053924f70855f7b3098b | |
| parent | a794d31daf67a801d59a38a35674deeb61034a4f [diff] |
Use the backdrop filter's clip for synthetic effects and layers
Previously for a synthetic effect and the associated synthesized mask
layer, we used the clip that introduce the synthetic effect as their
clip state, causing incorrect clipping of backdrop filters.
Now use the clip of the backdrop filter for synthetic effects and
layers to avoid the problem.
ClipPaintPropertyNode rounded_clip
ClipPaintPropertyNode rect_clip
EffectPaintPropertyNode backdrop_filter clip=rect_clip
The cc effect tree is like
mask_isolation (backdrop filter moved here)
/ \
mask_effect node_for_backdrop_filter
When we create the cc node for backdrop_filter, we find that there is
an ancestor clip (rounded_clip) needs a synthetic effect and synthesized
mask, so create mask_isolation and mask_effect nodes and a mask clip
layer. To let the backdrop filter access the correct backdrop, we move
the backdrop filter up to mask_isolation, requiring that mask_isolation
to use the backdrop_filter's clip (rect_clip) instead of the clip
(rounded_clip) that introduces the synthetic effect, to ensure the
backdrop filter is correctly clipped. This in turn requires that
mask_effect and the mask layer also use rect_clip as their clip state to
ensure proper clip hierarchy.
Bug: 1077137
Change-Id: Ib9c3cc7e8db5b1b261b3a758f2fb6680e0f5ab1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183198
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#766158}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!