commit | ee3228e0cb8b0abc1a6e487345ece9fe5868e321 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Fri May 08 14:04:31 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri May 08 14:30:09 2020 |
tree | 6fff3aa1b60b2fe4a4cdff80b6b236fc3bdd30b7 | |
parent | df7fc2ece226676b8398ece13ddfd31b4f1eca5c [diff] |
Reland: "[FlexNG] Make ComputeMinMaxSizes cache more precise." This is a reland of 044aeb3ed3364905cc185d67eb947c7ca3c13741 The initial patch was reverted due to an MSAN failure. This was caused by MinMaxSizesResult::depends_on_percentage_block_size not being initialized within the NGFieldsetLayoutAlgorithm. This reland always initialises depends_on_percentage_block_size to false. This also adds some documentation not present in the initial patch. Original change's description: Previously our cache was imprecise, we recalculate our min/max sizes when we didn't strictly need to, as we didn't know if we'd have a %-block-size replaced element beneath us. This patch changes ComputeMinMaxSizes to return a MinMaxSizesResult (instead of just MinMaxSizes). This contains an additional bit of information to indicate if this sub-tree depended on the %-block-size given to it. For most things, this will return false. For legacy layout roots we always assume that they have children which depend on the %-block-size (and why we initialize: intrinsic_logical_widths_depends_on_percentage_block_size_ to true). Along with this change, the cache changes in the following way: - We store an addition bit of information on LayoutBox to store the bit of information from ComputeMinMaxSizes. - We calculate the %-block-size for our children up-front, this means each of the algorithms don't have to do this. - With these changes, the cache can now hit, when the %-block-size given to us changes. \o/ Bug: 845235 Change-Id: I6c7e79c5ad787291ba2eeb4d1eebb5437f1934fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189620 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#766826}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!